Addon-Vitest: Support vite/vitest config with deferred export#33755
Merged
valentinpalkovic merged 2 commits intoFeb 4, 2026
Conversation
Contributor
📝 WalkthroughWalkthroughExtends the Vitest addon's configuration update logic to handle config objects defined via variable indirection and wrapped in Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
✨ Finishing touches
Comment |
|
View your CI Pipeline Execution ↗ for commit c633a79
☁️ Nx Cloud last updated this comment at |
ndelangen
approved these changes
Feb 4, 2026
This was referenced Feb 4, 2026
Merged
valentinpalkovic
added a commit
that referenced
this pull request
Feb 4, 2026
…nfig-with-deferred-export Addon-Vitest: Support vite/vitest config with deferred export (cherry picked from commit 23494ee)
This was referenced Mar 11, 2026
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33753
What I did
The Vitest addon’s config updater (
updateVitestFile) previously only supported config files that export the config inline, e.g.export default defineConfig({ ... }). It did not support the pattern where the config is assigned to a variable and exported on a separate line:This pattern is common in setups like TanStack Start and other projects that build the config in multiple steps. For those, the addon’s postinstall never merged in the Vitest/Storybook test configuration.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
export default configpattern (e.g. a TanStack Start app, or a minimalvite.config.tswithconst config = defineConfig({...}); export default config).path,storybookTest), thedirnamehelper if needed, and thetestblock (withprojectsand the Storybook test config) are merged into the same object that is exported (the one assigned toconfig).Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit
New Features
defineConfigpatterns and indirect variable references.Tests
defineConfigpatterns.