Addon-Vitest: Append Storybook project to existing test.projects array without double nesting#33708
Merged
valentinpalkovic merged 1 commit intoJan 29, 2026
Conversation
…y without double nesting
Contributor
📝 WalkthroughWalkthroughIntroduces multi-project handling for Vitest configuration merging. A new helper detects existing test.projects arrays in target configs. When present, template project configurations are appended to the array. Additionally, a test case validates that storybook projects are appended to existing projects without duplication or nesting issues. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
✨ Finishing touches
Comment |
|
View your CI Pipeline Execution ↗ for commit df1d201
☁️ Nx Cloud last updated this comment at |
ghengeveld
approved these changes
Jan 29, 2026
Merged
10 tasks
valentinpalkovic
added a commit
that referenced
this pull request
Jan 30, 2026
…ent-double-nesting Addon-Vitest: Append Storybook project to existing test.projects array without double nesting (cherry picked from commit 5bbb915)
24 tasks
This was referenced Jan 30, 2026
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33706
What I did
When running the postinstall script for
@storybook/addon-vitest, the migration logic could incorrectly wrap an existing Vitest config that already used aprojectsarray inside a new project object. That produced an invalid double-nested structure (test.projects[0].test.projects) and broke Vitest.Result: A config like:
is now updated to add the storybook project as a third item in
projects, instead of wrapping client/server in an extra project and breaking the structure.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
vitest.config.tswithtest.projects(e.g. client + server), add/init@storybook/addon-vitest.vitest.config.tsis updated so the storybook project is a new entry in the existingprojectsarray, not a wrapper around the previous config.npx vitest --project=storybookand ensure tests run.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-33708-sha-df1d2018. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-33708-sha-df1d2018 sandboxor in an existing project withnpx storybook@0.0.0-pr-33708-sha-df1d2018 upgrade.More information
0.0.0-pr-33708-sha-df1d2018valentin/addon-vitest-prevent-double-nestingdf1d20181769683493)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=33708Summary by CodeRabbit
Bug Fixes
Tests
✏️ Tip: You can customize this high-level summary in your review settings.