-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Build: Update and change the yarn-pnp example to use Vue #32979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1e5021e
Build: Update and change the yarn-pnp example to use Vue
yannbf 110b0e5
add yarn-pnp test to CI
yannbf 4df26a4
Discard changes to test-storybooks/yarn-pnp/yarn.lock
ndelangen 947b947
checkin empty lockfile
ndelangen c80ffb3
fix pnp issues
yannbf 465b020
try out without getAbsolutePath
ndelangen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| executor: | ||
| name: sb_playwright | ||
| class: medium | ||
|
|
||
| steps: | ||
| - git-shallow-clone/checkout_advanced: | ||
| clone_options: '--depth 1 --verbose' | ||
| - attach_workspace: | ||
| at: . | ||
| - run: | ||
| name: Install dependencies | ||
| command: yarn install --no-immutable | ||
| working_directory: test-storybooks/yarn-pnp | ||
| environment: | ||
| YARN_ENABLE_IMMUTABLE_INSTALLS: false | ||
| - run: | ||
| name: Run Storybook smoke test | ||
| command: yarn storybook --smoke-test | ||
| working_directory: test-storybooks/yarn-pnp | ||
|
|
||
| - report-workflow-on-failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,16 @@ | ||
| import { fileURLToPath } from "node:url"; | ||
| import { dirname } from "node:path"; | ||
| import type { StorybookConfig } from '@storybook/react-vite'; | ||
|
|
||
| const config: StorybookConfig = { | ||
| "stories": [ | ||
| "../src/**/*.mdx", | ||
| "../src/**/*.stories.@(js|jsx|mjs|ts|tsx)" | ||
| ], | ||
| "addons": [ | ||
| getAbsolutePath("@chromatic-com/storybook"), | ||
| getAbsolutePath("@storybook/addon-docs"), | ||
| getAbsolutePath("@storybook/addon-a11y"), | ||
| getAbsolutePath("@storybook/addon-vitest") | ||
| ], | ||
| "framework": { | ||
| "name": getAbsolutePath("@storybook/react-vite"), | ||
| "options": {} | ||
| } | ||
| }; | ||
| export default config; | ||
|
|
||
| function getAbsolutePath(value: string): any { | ||
| return dirname(fileURLToPath(import.meta.resolve(`${value}/package.json`))); | ||
| } | ||
| import type { StorybookConfig } from "@storybook/vue3-vite"; | ||
|
|
||
| const config: StorybookConfig = { | ||
| stories: ["../src/**/*.mdx", "../src/**/*.stories.@(js|jsx|mjs|ts|tsx)"], | ||
| addons: [ | ||
| "@chromatic-com/storybook", | ||
| "@storybook/addon-docs", | ||
| "@storybook/addon-a11y", | ||
| "@storybook/addon-vitest", | ||
| ], | ||
| framework: { | ||
| name: "@storybook/vue3-vite", | ||
| options: {}, | ||
| }, | ||
| }; | ||
| export default config; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| import * as a11yAddonAnnotations from "@storybook/addon-a11y/preview"; | ||
| import { setProjectAnnotations } from '@storybook/react-vite'; | ||
| import * as projectAnnotations from './preview'; | ||
| import { setProjectAnnotations } from "@storybook/vue3-vite"; | ||
| import * as projectAnnotations from "./preview"; | ||
|
|
||
| // This is an important step to apply the right configuration when testing your stories. | ||
| // More info at: https://storybook.js.org/docs/api/portable-stories/portable-stories-vitest#setprojectannotations | ||
| setProjectAnnotations([a11yAddonAnnotations, projectAnnotations]); | ||
| setProjectAnnotations([a11yAddonAnnotations, projectAnnotations]); |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,16 @@ | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <link rel="icon" type="image/svg+xml" href="/vite.svg" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Vite + React + TS</title> | ||
| </head> | ||
| <body> | ||
| <div id="root"></div> | ||
| <script type="module" src="/src/main.tsx"></script> | ||
| </body> | ||
| </html> | ||
|
|
||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <link rel="icon" type="image/svg+xml" href="/vite.svg" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>vue3-vite</title> | ||
| </head> | ||
|
|
||
| <body> | ||
| <div id="app"></div> | ||
| <script type="module" src="/src/main.ts"></script> | ||
| </body> | ||
|
|
||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.