Skip to content

Build: Update and change the yarn-pnp example to use Vue#32979

Merged
ndelangen merged 6 commits into
nextfrom
yann/update-yarn-pnp-example
Nov 10, 2025
Merged

Build: Update and change the yarn-pnp example to use Vue#32979
ndelangen merged 6 commits into
nextfrom
yann/update-yarn-pnp-example

Conversation

@yannbf
Copy link
Copy Markdown
Member

@yannbf yannbf commented Nov 7, 2025

Closes #

What I did

This changes the yarn-pnp internal test storybook example to use Vue, as it's a non-React framework which would help detect issues that wouldn't happen otherwise in React.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • New Features

    • Added a CI job to run Yarn PnP Storybook smoke tests, triggered after builds in daily/merged/normal workflows.
  • Improvements

    • Migrated the test Storybook from React to Vue 3, including new Vue components and stories.
    • Added build-storybook script and integrated test tooling (Vitest + Playwright) for Storybook end-to-end checks.

@yannbf yannbf self-assigned this Nov 7, 2025
@yannbf yannbf added build Internal-facing build tooling & test updates ci:normal labels Nov 7, 2025
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Nov 7, 2025

View your CI Pipeline Execution ↗ for commit 465b020

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 47s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-10 09:58:47 UTC

@coderabbitai

This comment was marked as spam.

coderabbitai[bot]

This comment was marked as spam.

@yannbf yannbf force-pushed the yann/update-yarn-pnp-example branch from 897bb0e to a2c9cf2 Compare November 7, 2025 11:31
@yannbf yannbf force-pushed the yann/update-yarn-pnp-example branch from 92f398b to 110b0e5 Compare November 7, 2025 12:04
@storybook-app-bot
Copy link
Copy Markdown

Package Benchmarks

Commit: 465b020, ran on 10 November 2025 at 09:48:43 UTC

The following packages have significant changes to their size or dependencies:

@storybook/react-native-web-vite

Before After Difference
Dependency count 156 157 🚨 +1 🚨
Self size 31 KB 31 KB 🚨 +126 B 🚨
Dependency size 23.05 MB 23.11 MB 🚨 +64 KB 🚨
Bundle Size Analyzer Link Link

@ndelangen ndelangen merged commit a3dff19 into next Nov 10, 2025
63 checks passed
@ndelangen ndelangen deleted the yann/update-yarn-pnp-example branch November 10, 2025 09:58
@github-actions github-actions Bot mentioned this pull request Nov 10, 2025
12 tasks
@yannbf yannbf added the empathy label Nov 11, 2025
@coderabbitai coderabbitai Bot mentioned this pull request Nov 26, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal empathy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants