Revert "CLI: Fix sb CLI by explicitly exporting bin/index.cjs from storybook package"#31933
Closed
ghengeveld wants to merge 1 commit into
Closed
Revert "CLI: Fix sb CLI by explicitly exporting bin/index.cjs from storybook package"#31933ghengeveld wants to merge 1 commit into
sb CLI by explicitly exporting bin/index.cjs from storybook package"#31933ghengeveld wants to merge 1 commit into
Conversation
…m `storybook` package"
Contributor
There was a problem hiding this comment.
LGTM
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit 2362479.
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 536 | 537 | 🚨 +1 🚨 |
| Self size | 903 KB | 903 KB | 0 B |
| Dependency size | 58.92 MB | 58.97 MB | 🚨 +49 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/nextjs-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 130 | 130 | 0 |
| Self size | 3.08 MB | 3.08 MB | 0 B |
| Dependency size | 22.25 MB | 22.27 MB | 🚨 +17 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-native-web-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 161 | 161 | 0 |
| Self size | 35 KB | 35 KB | 🎉 -129 B 🎉 |
| Dependency size | 23.26 MB | 23.28 MB | 🚨 +17 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 120 | 120 | 0 |
| Self size | 32 KB | 32 KB | 0 B |
| Dependency size | 20.20 MB | 20.22 MB | 🚨 +17 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 285 | 285 | 0 |
| Self size | 25 KB | 25 KB | 0 B |
| Dependency size | 43.52 MB | 43.53 MB | 🚨 +17 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/vue3-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 104 | 104 | 0 |
| Self size | 34 KB | 34 KB | 0 B |
| Dependency size | 42.70 MB | 42.73 MB | 🚨 +32 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 217 | 217 | 0 |
| Self size | 582 KB | 582 KB | 0 B |
| Dependency size | 94.79 MB | 94.81 MB | 🚨 +17 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 186 | 186 | 0 |
| Self size | 31 KB | 31 KB | 0 B |
| Dependency size | 78.89 MB | 78.91 MB | 🚨 +17 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preset-react-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 176 | 176 | 0 |
| Self size | 24 KB | 24 KB | 0 B |
| Dependency size | 30.35 MB | 30.36 MB | 🚨 +17 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #31922
Greptile Summary
Reverts changes that explicitly exported
bin/index.cjsin package.json exports map, returning to standard Node.js package binary exposure through thebinfield../bin/index.cjsexport fromcode/core/package.jsonexports mapcode/core/scripts/helpers/generatePackageJsonFile.tsthat added CLI entry point exportsbinfield specification on line 422ERR_PACKAGE_PATH_NOT_EXPORTEDerror when using directrequire()ofstorybook/bin/index.cjs