Skip to content

Revert "CLI: Fix sb CLI by explicitly exporting bin/index.cjs from storybook package"#31933

Closed
ghengeveld wants to merge 1 commit into
nextfrom
revert-31922-export-storybook-bin-index.cjs
Closed

Revert "CLI: Fix sb CLI by explicitly exporting bin/index.cjs from storybook package"#31933
ghengeveld wants to merge 1 commit into
nextfrom
revert-31922-export-storybook-bin-index.cjs

Conversation

@ghengeveld
Copy link
Copy Markdown
Member

@ghengeveld ghengeveld commented Jul 2, 2025

Reverts #31922

Greptile Summary

Reverts changes that explicitly exported bin/index.cjs in package.json exports map, returning to standard Node.js package binary exposure through the bin field.

  • Removes explicit ./bin/index.cjs export from code/core/package.json exports map
  • Reverts changes in code/core/scripts/helpers/generatePackageJsonFile.ts that added CLI entry point exports
  • CLI binary remains accessible through standard bin field specification on line 422
  • May reintroduce ERR_PACKAGE_PATH_NOT_EXPORTED error when using direct require() of storybook/bin/index.cjs

@ghengeveld ghengeveld added bug patch:yes Bugfix & documentation PR that need to be picked to main branch ci:merged Run the CI jobs that normally run when merged. labels Jul 2, 2025
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

@ghengeveld ghengeveld removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jul 2, 2025
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Jul 2, 2025

View your CI Pipeline Execution ↗ for commit 2362479.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 12s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-02 14:10:04 UTC

@storybook-app-bot
Copy link
Copy Markdown

Package Benchmarks

Commit: 2362479, ran on 2 July 2025 at 13:59:35 UTC

The following packages have significant changes to their size or dependencies:

@storybook/nextjs

Before After Difference
Dependency count 536 537 🚨 +1 🚨
Self size 903 KB 903 KB 0 B
Dependency size 58.92 MB 58.97 MB 🚨 +49 KB 🚨
Bundle Size Analyzer Link Link

@storybook/nextjs-vite

Before After Difference
Dependency count 130 130 0
Self size 3.08 MB 3.08 MB 0 B
Dependency size 22.25 MB 22.27 MB 🚨 +17 KB 🚨
Bundle Size Analyzer Link Link

@storybook/react-native-web-vite

Before After Difference
Dependency count 161 161 0
Self size 35 KB 35 KB 🎉 -129 B 🎉
Dependency size 23.26 MB 23.28 MB 🚨 +17 KB 🚨
Bundle Size Analyzer Link Link

@storybook/react-vite

Before After Difference
Dependency count 120 120 0
Self size 32 KB 32 KB 0 B
Dependency size 20.20 MB 20.22 MB 🚨 +17 KB 🚨
Bundle Size Analyzer Link Link

@storybook/react-webpack5

Before After Difference
Dependency count 285 285 0
Self size 25 KB 25 KB 0 B
Dependency size 43.52 MB 43.53 MB 🚨 +17 KB 🚨
Bundle Size Analyzer Link Link

@storybook/vue3-vite

Before After Difference
Dependency count 104 104 0
Self size 34 KB 34 KB 0 B
Dependency size 42.70 MB 42.73 MB 🚨 +32 KB 🚨
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 217 217 0
Self size 582 KB 582 KB 0 B
Dependency size 94.79 MB 94.81 MB 🚨 +17 KB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 186 186 0
Self size 31 KB 31 KB 0 B
Dependency size 78.89 MB 78.91 MB 🚨 +17 KB 🚨
Bundle Size Analyzer Link Link

@storybook/preset-react-webpack

Before After Difference
Dependency count 176 176 0
Self size 24 KB 24 KB 0 B
Dependency size 30.35 MB 30.36 MB 🚨 +17 KB 🚨
Bundle Size Analyzer Link Link

@ghengeveld ghengeveld closed this Jul 2, 2025
@kasperpeulen kasperpeulen deleted the revert-31922-export-storybook-bin-index.cjs branch April 4, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci:merged Run the CI jobs that normally run when merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant