CLI: Fix sb CLI by explicitly exporting bin/index.cjs from storybook package#31922
Merged
Conversation
Contributor
There was a problem hiding this comment.
LGTM
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit 01fa8b2.
☁️ Nx Cloud last updated this comment at |
ndelangen
approved these changes
Jul 1, 2025
This was referenced Jul 1, 2025
Merged
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 51 | 51 | 0 |
| Self size | 31.75 MB | 31.73 MB | 🎉 -19 KB 🎉 |
| Dependency size | 17.43 MB | 17.43 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/nextjs
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 536 | 537 | 🚨 +1 🚨 |
| Self size | 903 KB | 903 KB | 0 B |
| Dependency size | 58.92 MB | 58.97 MB | 🚨 +49 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/nextjs-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 130 | 130 | 0 |
| Self size | 3.08 MB | 3.08 MB | 0 B |
| Dependency size | 22.25 MB | 22.27 MB | 🚨 +17 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-native-web-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 161 | 161 | 0 |
| Self size | 35 KB | 35 KB | 🎉 -129 B 🎉 |
| Dependency size | 23.26 MB | 23.28 MB | 🚨 +17 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 120 | 120 | 0 |
| Self size | 32 KB | 32 KB | 0 B |
| Dependency size | 20.20 MB | 20.22 MB | 🚨 +17 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 285 | 285 | 0 |
| Self size | 25 KB | 25 KB | 0 B |
| Dependency size | 43.52 MB | 43.53 MB | 🚨 +17 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/vue3-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 104 | 104 | 0 |
| Self size | 34 KB | 34 KB | 0 B |
| Dependency size | 42.70 MB | 42.73 MB | 🚨 +32 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
sb
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 52 | 52 | 0 |
| Self size | 1 KB | 1 KB | 0 B |
| Dependency size | 49.18 MB | 49.16 MB | 🎉 -19 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/preset-react-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 176 | 176 | 0 |
| Self size | 24 KB | 24 KB | 0 B |
| Dependency size | 30.35 MB | 30.36 MB | 🚨 +17 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
ghengeveld
added a commit
that referenced
this pull request
Jul 8, 2025
….cjs CLI: Fix `sb` CLI by explicitly exporting `bin/index.cjs` from `storybook` package (cherry picked from commit 06c6056)
This was referenced Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31807
What I did
Added an entry for
./bin/index.cjsto theexportsmap for thestorybookpackage so thatrequire('storybook/bin/index.cjs')does not throwERR_PACKAGE_PATH_NOT_EXPORTED.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-31922-sha-01fa8b2d. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-31922-sha-01fa8b2d sandboxor in an existing project withnpx storybook@0.0.0-pr-31922-sha-01fa8b2d upgrade.More information
0.0.0-pr-31922-sha-01fa8b2dexport-storybook-bin-index.cjs01fa8b2d1751385491)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=31922Greptile Summary
Fixed the Storybook CLI (
sb) by adding./bin/index.cjsto the package exports map, resolving theERR_PACKAGE_PATH_NOT_EXPORTEDerror when running CLI commands likenpx sb@latest upgrade../bin/index.cjsincode/core/package.jsonrequire()) and ESM import patterns