Skip to content

perf(addons): switch to empathic for upwards FS traversal #31388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
43081j wants to merge 1 commit into from
Closed

perf(addons): switch to empathic for upwards FS traversal #31388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/addons/vitest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@
"@vitest/browser": "^3.1.1",
"@vitest/runner": "^3.1.1",
"boxen": "^8.0.1",
"empathic": "^1.1.0",
"es-toolkit": "^1.36.0",
"execa": "^8.0.1",
"find-up": "^7.0.0",
"istanbul-lib-report": "^3.0.1",
"pathe": "^1.1.2",
"picocolors": "^1.1.0",
Expand Down
4 changes: 2 additions & 2 deletions code/addons/vitest/src/node/vitest-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import type {
StoryIndexEntry,
} from 'storybook/internal/types';

import { findUp } from 'find-up';
import { any as findUp } from 'empathic/find';
import path, { dirname, join, normalize } from 'pathe';
import slash from 'slash';

Expand Down Expand Up @@ -76,7 +76,7 @@ export class VitestManager {
: { enabled: false }
) as CoverageOptions;

const vitestWorkspaceConfig = await findUp([
const vitestWorkspaceConfig = findUp([
...VITEST_WORKSPACE_FILE_EXTENSION.map((ext) => `vitest.workspace.${ext}`),
...VITEST_CONFIG_FILE_EXTENSIONS.map((ext) => `vitest.config.${ext}`),
]);
Expand Down
2 changes: 1 addition & 1 deletion code/addons/vitest/src/postinstall.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ import {
import { readConfig, writeConfig } from 'storybook/internal/csf-tools';
import { colors, logger } from 'storybook/internal/node-logger';

import { any as findUp } from 'empathic/find';
// eslint-disable-next-line depend/ban-dependencies
import { $ } from 'execa';
import { findUp } from 'find-up';
import { dirname, extname, join, relative, resolve } from 'pathe';
import picocolors from 'picocolors';
import prompts from 'prompts';
Expand Down
9 changes: 8 additions & 1 deletion code/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6023,9 +6023,9 @@ __metadata:
"@vitest/browser": "npm:^3.1.1"
"@vitest/runner": "npm:^3.1.1"
boxen: "npm:^8.0.1"
empathic: "npm:^1.1.0"
es-toolkit: "npm:^1.36.0"
execa: "npm:^8.0.1"
find-up: "npm:^7.0.0"
istanbul-lib-report: "npm:^3.0.1"
pathe: "npm:^1.1.2"
picocolors: "npm:^1.1.0"
Expand Down Expand Up @@ -12966,6 +12966,13 @@ __metadata:
languageName: node
linkType: hard

"empathic@npm:^1.1.0":
version: 1.1.0
resolution: "empathic@npm:1.1.0"
checksum: 10c0/ed906c4ad6dabe1477ed00d6420f79eff8ac72e2eb580aab42406f50160fd34d66e8381e92b405e96d75a826a840706af261fd397c3e7db4d1a293d23e2e72f7
languageName: node
linkType: hard

"encodeurl@npm:~1.0.2":
version: 1.0.2
resolution: "encodeurl@npm:1.0.2"
Expand Down