perf(addons): switch to empathic for upwards FS traversal#31388
Closed
43081j wants to merge 1 commit into
Closed
Conversation
43081j
added a commit
to 43081j/storybook
that referenced
this pull request
May 6, 2025
Part of consolidating every `find-*` dependency into one. Follow-on of storybookjs#31388.
Contributor
There was a problem hiding this comment.
LGTM
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
43081j
added a commit
to 43081j/storybook
that referenced
this pull request
May 6, 2025
43081j
added a commit
to 43081j/storybook
that referenced
this pull request
May 6, 2025
Follow-on of storybookjs#31388. Switches to using `empathic` for all upwards FS traversal.
Switches to `empathic` for finding parent files, a much faster library. Part of consolidating every `find-*` dependency into just one.
035a5b0 to
ffae911
Compare
43081j
added a commit
to 43081j/storybook
that referenced
this pull request
May 6, 2025
Part of consolidating every `find-*` dependency into one. Follow-on of storybookjs#31388.
43081j
added a commit
to 43081j/storybook
that referenced
this pull request
May 6, 2025
43081j
added a commit
to 43081j/storybook
that referenced
this pull request
May 6, 2025
Follow-on of storybookjs#31388. Switches to using `empathic` for all upwards FS traversal.
43081j
added a commit
to 43081j/storybook
that referenced
this pull request
May 6, 2025
Follow-on of storybookjs#31388.
|
View your CI Pipeline Execution ↗ for commit ffae911.
☁️ Nx Cloud last updated this comment at |
Contributor
Author
|
This and my other branches may actually be replaced by #31338 if we get that PR over the line, this can be closed and my other branches deleted I'll switch this to a draft for now |
Contributor
|
@43081j this can be closed now? |
Contributor
Author
|
it can! thanks for pinging me 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches to
empathicfor finding parent files, a much faster library.Part of consolidating every
find-*dependency into just one.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Existing tests should cover it.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.Greptile Summary
This PR replaces the
find-uppackage withempathicfor file system traversal in the Storybook Vitest addon, aiming to improve performance during configuration file discovery.startVitestmethod invitest-manager.tsto use synchronousempathic/findinstead of asyncfind-uppackage.jsonto replacefind-updependency withempathicpostinstall.tsto useempathic/findfor upwards file system traversal💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!