Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Reduce bun usage #28828

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Build: Reduce bun usage #28828

merged 1 commit into from
Aug 7, 2024

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Aug 7, 2024

Follow-up of #28796

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.3 MB 76.3 MB 0 B 0.66 0%
initSize 171 MB 171 MB 0 B -0.73 0%
diffSize 95 MB 95 MB 0 B -0.73 0%
buildSize 7.42 MB 7.42 MB 0 B -1.22 0%
buildSbAddonsSize 1.61 MB 1.61 MB 0 B -1.22 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.29 MB 2.29 MB 0 B -0.65 0%
buildSbPreviewSize 351 kB 351 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.45 MB 4.45 MB 0 B -1.16 0%
buildPreviewSize 2.97 MB 2.97 MB 0 B -1.22 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 27.1s 7.2s -19s -880ms -1.27 🔰-272.4%
generateTime 24s 22.4s -1s -565ms 0.09 -7%
initTime 22.8s 18.8s -4s -6ms -0.91 -21.3%
buildTime 12.5s 12.2s -263ms -1.38 -2.1%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 7.8s 9.7s 1.9s 0.84 19.7%
devManagerResponsive 4.5s 5.6s 1.1s 0.35 20.6%
devManagerHeaderVisible 750ms 1s 283ms 1.03 27.4%
devManagerIndexVisible 784ms 1s 276ms 0.95 26%
devStoryVisibleUncached 1.3s 1.3s 60ms 0.7 4.4%
devStoryVisible 796ms 1s 276ms 0.83 25.7%
devAutodocsVisible 699ms 828ms 129ms 0.54 15.6%
devMDXVisible 653ms 895ms 242ms 1.47 🔺27%
buildManagerHeaderVisible 654ms 823ms 169ms 0.26 20.5%
buildManagerIndexVisible 656ms 830ms 174ms 0.25 21%
buildStoryVisible 695ms 874ms 179ms 0.22 20.5%
buildAutodocsVisible 663ms 687ms 24ms -0.55 3.5%
buildMDXVisible 587ms 671ms 84ms -0.21 12.5%

Greptile Summary

The pull request focuses on replacing bun with jiti for executing pre and post build scripts across various build scripts to standardize the process.

  • Updated scripts/prepare/addon-bundle.ts to use jiti for pre and post build scripts.
  • Modified scripts/prepare/bundle.ts to replace bun with jiti for executing pre and post build scripts.
  • Changed scripts/prepare/tsc.ts to utilize jiti instead of bun for pre and post build script execution.

Ensure that jiti handles all scenarios previously managed by bun without issues.

@ndelangen ndelangen changed the title reduce bun usage Build: Reduce bun usage Aug 7, 2024
@ndelangen ndelangen changed the title Build: Reduce bun usage Build: Reduce bun usage Aug 7, 2024
@ndelangen ndelangen self-assigned this Aug 7, 2024
@ndelangen ndelangen added build Internal-facing build tooling & test updates ci:normal labels Aug 7, 2024
Copy link

nx-cloud bot commented Aug 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9605338. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen marked this pull request as ready for review August 7, 2024 14:08
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@ndelangen ndelangen merged commit bbfdf58 into next Aug 7, 2024
59 of 64 checks passed
@ndelangen ndelangen deleted the norbert/decrease-bun-use branch August 7, 2024 14:11
@github-actions github-actions bot mentioned this pull request Aug 7, 2024
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant