-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Replace esbuild-register
by jiti
#28796
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 44ee488. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
30 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Appreciate the PR @tobiasdiez The Ci is failing however. |
The error comes from
Jiti currently does not provide support for top level await (but it's next version will): unjs/jiti#72 |
Yeah, I'd welcome a replacement. I'll help out, as it would be amazing to get rid of |
esbuild-register
by jiti
Replaces: #28046
What I did
Since the migration to bun seems to encounter issues and esbuild-register is not working with new node versions, this PR propes to migrate to jiti for the ts executation during development.
Only a few very minimal changes were necessary to execute the scripts with jiti.
Moreover, I've added bun as a dev dependency of the scripts package so that one doesn't need to install it separately.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Run
yarn start
as suggested in the contribution guidelines.This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
This pull request replaces
esbuild-register
withjiti
for TypeScript execution during development to address compatibility issues with newer Node.js versions..circleci/config.yml
to usejiti
instead ofesbuild-register
.package.json
files across multiple addons and frameworks to replaceesbuild-register
withjiti
incheck
andprep
scripts.bun
as a dev dependency in several packages to streamline the development setup.