Skip to content

Sandbox: Use npm to create Qwik sandboxes #26340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JReinhold merged 1 commit into from
Mar 8, 2024
Merged

Sandbox: Use npm to create Qwik sandboxes #26340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/lib/cli/src/sandbox-templates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ const baseTemplates = {
},
'qwik-vite/default-ts': {
name: 'Qwik CLI Latest (Vite | TypeScript)',
script: 'yarn create qwik basic {{beforeDir}}',
script: 'npm create qwik basic {{beforeDir}}',

@yannbf yannbf Mar 6, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a safe change? I wonder if this will work given that it will end up generating npm lock files, and further down the sandbox pipeline things might not work. Can you trigger the sandbox generation for this branch?

I honestly don't remember why we use Yarn 1 in the sandboxes, might be worth experimenting switching the Yarn version as well, maybe

@JReinhold JReinhold Mar 7, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a safe change? I wonder if this will work given that it will end up generating npm lock files, and further down the sandbox pipeline things might not work. Can you trigger the sandbox generation for this branch?

Did a temporary run here, looks like it worked fine. https://github.com/storybookjs/storybook/actions/runs/8171749412/job/22340650305#step:11:221

I honestly don't remember why we use Yarn 1 in the sandboxes, might be worth experimenting switching the Yarn version as well, maybe

It was probably the easiest, but I think it's pretty bad now, especially because StackBlitz doesn't like it too much (our StackBlitz runs npm install && yarn storybook 🙃)

I think the right thing to do here is to migrate sandboxes to npm - we don't need to prescribe users a certain package manager so the default should be fine. I tried this some month ago but weren't successful in a small timebox, I wanna try again though.

// TODO: The community template does not provide standard stories, which is required for e2e tests. Reenable once it does.
inDevelopment: true,
expected: {
Expand Down