Sandbox: Use npm to create Qwik sandboxes

[JReinhold]

What I did

Changed the script to use npm instead of yarn 1 to generate the before-storybook directory with Qwik. Qwik 1.5 removed support for Yarn 1 in their CLI.

See https://github.com/storybookjs/storybook/actions/runs/8165928805/job/22323853208#step:11:240

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

[yannbf]

is this a safe change? I wonder if this will work given that it will end up generating npm lock files, and further down the sandbox pipeline things might not work. Can you trigger the sandbox generation for this branch?

I honestly don't remember why we use Yarn 1 in the sandboxes, might be worth experimenting switching the Yarn version as well, maybe

[JReinhold]

is this a safe change? I wonder if this will work given that it will end up generating npm lock files, and further down the sandbox pipeline things might not work. Can you trigger the sandbox generation for this branch?

Did a temporary run here, looks like it worked fine. https://github.com/storybookjs/storybook/actions/runs/8171749412/job/22340650305#step:11:221

I honestly don't remember why we use Yarn 1 in the sandboxes, might be worth experimenting switching the Yarn version as well, maybe

It was probably the easiest, but I think it's pretty bad now, especially because StackBlitz doesn't like it too much (our StackBlitz runs npm install && yarn storybook 🙃)

I think the right thing to do here is to migrate sandboxes to npm - we don't need to prescribe users a certain package manager so the default should be fine. I tried this some month ago but weren't successful in a small timebox, I wanna try again though.