Revert: Sandboxes: Use Node 18 to generate Angular prerelease sandboxes#24100
Merged
Conversation
kasperpeulen
requested review from
JReinhold,
ndelangen,
valentinpalkovic,
vanessayuenn and
yannbf
as code owners
kasperpeulen
added
build
yannbf
approved these changes
Sep 7, 2023
25 tasks
kasperpeulen
added
the
patch:yes
storybook-bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
…rerelease-sandbox Revert: Sandboxes: Use Node 18 to generate Angular prerelease sandboxes (cherry picked from commit 32e8c0b)
Merged
10 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
…rerelease-sandbox Revert: Sandboxes: Use Node 18 to generate Angular prerelease sandboxes (cherry picked from commit 32e8c0b)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
…rerelease-sandbox Revert: Sandboxes: Use Node 18 to generate Angular prerelease sandboxes (cherry picked from commit 32e8c0b)
Member
|
Why was this needed? Could we keep a record of the reason why we revert things in the PR doing the revert? |
Member
Author
|
@ndelangen I discussed this with @JReinhold thursday. It seems that this PR never really worked: We needed to revert this to unblock the daily jobs to release a patch PR. I think it would be good to re-revert this in a way, that it works, as know the prerelease sandbox is back inDevelopment, and still causing issues in the sandbox workflow. I first need to some other empathy tasks, but otherwise I will pass this over to the next empathy person. |
github-actions
Bot
added
the
patch:done
ndelangen
removed
the
patch:yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #24033