Sandboxes: Use Node 18 to generate Angular prerelease sandboxes#24033
Merged
Conversation
JReinhold
commented
Aug 31, 2023
| angular-prerelease-sandbox: | ||
| executor: | ||
| class: large | ||
| name: sb_playwright |
Contributor
Author
There was a problem hiding this comment.
sb_playwright is on Node 18, which is lucky for us.
yannbf
reviewed
Aug 31, 2023
yannbf
reviewed
Aug 31, 2023
yannbf
reviewed
Aug 31, 2023
yannbf
reviewed
Aug 31, 2023
| env: | ||
| YARN_ENABLE_IMMUTABLE_INSTALLS: false | ||
| CLEANUP_SANDBOX_NODE_MODULES: true | ||
| strategy: |
Member
There was a problem hiding this comment.
Can you follow the instructions from line 7 of this file and make sure this change works as expected?
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
it failed on the very last character of the workflow, which I've fixed. I don't feel it's necessary to test it again.
yannbf
approved these changes
Sep 4, 2023
25 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
…dbox Sandboxes: Use Node 18 to generate Angular prerelease sandboxes (cherry picked from commit 81f61a0)
Merged
10 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
…dbox Sandboxes: Use Node 18 to generate Angular prerelease sandboxes (cherry picked from commit 81f61a0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
This PR fixes the issue with Angular prereleases not working in our CI anymore, because they require Node 18.
mainandnextinto one, using the strategy matrix feature instead.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
nextbranch because of the workflow rename, but here's a (cancelled) run where I log that the matrixes are set up correct: https://github.com/storybookjs/storybook/actions/runs/6037790919/job/16382747584This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>