Skip to content

Release tooling: Fix double run of publish workflow#23432

Merged
JReinhold merged 1 commit into
nextfrom
fix-double-publishing
Jul 13, 2023
Merged

Release tooling: Fix double run of publish workflow#23432
JReinhold merged 1 commit into
nextfrom
fix-double-publishing

Conversation

@JReinhold
Copy link
Copy Markdown
Contributor

@JReinhold JReinhold commented Jul 13, 2023

What I did

#23393 introduced an "apply" step to the publishing workflow, that committed the version bump to next-release/latest-release. This had the unfortunate side-effect that this commit would trigger a secondary run of the publish workflow, running simultaneously with the already running publish workflow (albeit a little behind). The secondary run would be a no-op, but it would fail in the end. The existing workflow would complete without errors.

You can see how this played out in the release of 7.0.27, with this being the real run and this being the secondary run triggered.

This PR adds a guard against that, by cancelling the workflow if it's triggered by a commit with [skip ci], and then add that string to the version bump commit.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@JReinhold JReinhold added patch:yes Bugfix & documentation PR that need to be picked to main branch build Internal-facing build tooling & test updates labels Jul 13, 2023
@JReinhold JReinhold self-assigned this Jul 13, 2023
Copy link
Copy Markdown
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JReinhold JReinhold merged commit 4f1fe59 into next Jul 13, 2023
@JReinhold JReinhold deleted the fix-double-publishing branch July 13, 2023 07:58
storybook-bot pushed a commit that referenced this pull request Jul 13, 2023
Release tooling: Fix double run of publish workflow

(cherry picked from commit 4f1fe59)
This was referenced Jul 13, 2023
storybook-bot pushed a commit that referenced this pull request Jul 13, 2023
Release tooling: Fix double run of publish workflow

(cherry picked from commit 4f1fe59)
storybook-bot pushed a commit that referenced this pull request Jul 13, 2023
Release tooling: Fix double run of publish workflow

(cherry picked from commit 4f1fe59)
storybook-bot pushed a commit that referenced this pull request Jul 13, 2023
Release tooling: Fix double run of publish workflow

(cherry picked from commit 4f1fe59)
storybook-bot pushed a commit that referenced this pull request Jul 13, 2023
Release tooling: Fix double run of publish workflow

(cherry picked from commit 4f1fe59)
storybook-bot pushed a commit that referenced this pull request Jul 13, 2023
Release tooling: Fix double run of publish workflow

(cherry picked from commit 4f1fe59)
storybook-bot pushed a commit that referenced this pull request Jul 13, 2023
Release tooling: Fix double run of publish workflow

(cherry picked from commit 4f1fe59)
storybook-bot pushed a commit that referenced this pull request Jul 14, 2023
Release tooling: Fix double run of publish workflow

(cherry picked from commit 4f1fe59)
storybook-bot pushed a commit that referenced this pull request Jul 14, 2023
Release tooling: Fix double run of publish workflow

(cherry picked from commit 4f1fe59)
storybook-bot pushed a commit that referenced this pull request Jul 15, 2023
Release tooling: Fix double run of publish workflow

(cherry picked from commit 4f1fe59)
storybook-bot pushed a commit that referenced this pull request Jul 15, 2023
Release tooling: Fix double run of publish workflow

(cherry picked from commit 4f1fe59)
storybook-bot pushed a commit that referenced this pull request Jul 17, 2023
Release tooling: Fix double run of publish workflow

(cherry picked from commit 4f1fe59)
storybook-bot pushed a commit that referenced this pull request Jul 17, 2023
Release tooling: Fix double run of publish workflow

(cherry picked from commit 4f1fe59)
storybook-bot pushed a commit that referenced this pull request Jul 17, 2023
Release tooling: Fix double run of publish workflow

(cherry picked from commit 4f1fe59)
storybook-bot pushed a commit that referenced this pull request Jul 17, 2023
Release tooling: Fix double run of publish workflow

(cherry picked from commit 4f1fe59)
storybook-bot pushed a commit that referenced this pull request Jul 17, 2023
Release tooling: Fix double run of publish workflow

(cherry picked from commit 4f1fe59)
storybook-bot pushed a commit that referenced this pull request Jul 17, 2023
Release tooling: Fix double run of publish workflow

(cherry picked from commit 4f1fe59)
storybook-bot pushed a commit that referenced this pull request Jul 18, 2023
Release tooling: Fix double run of publish workflow

(cherry picked from commit 4f1fe59)
@JReinhold JReinhold added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 18, 2023
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants