Release tooling: Defer version bumping to the publish step - Cherry picking #23393#23421
Merged
Conversation
Release tooling: Defer version bumping to the publish step (cherry picked from commit a930066)
ndelangen
approved these changes
Jul 12, 2023
shilman
approved these changes
Jul 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
This PR manually cherry-picks #23393 back to
mainso it has an immediate effect. It looked to be working onnext, as the prerelease PR only has deferred version bumps: https://github.com/storybookjs/storybook/pull/23414/files#diff-af9b72cb6dcf333969863361a126e03c67fb19ec94a062462e4d4bc3e2f801cb 💪(this also re-adds
CONTRIBUTING/RELEASING.md, I'm not sure why that was ever deleted onmain)Release tooling: Defer version bumping to the publish step
(cherry picked from commit a930066)
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]