Skip to content

DangerJS: Fix missing patch label message#23420

Closed
JReinhold wants to merge 1 commit into
nextfrom
fix-danger-patch
Closed

DangerJS: Fix missing patch label message#23420
JReinhold wants to merge 1 commit into
nextfrom
fix-danger-patch

Conversation

@JReinhold
Copy link
Copy Markdown
Contributor

What I did

If no patch labels was given DangerJS would fail with "PR is not labeled with one of: []".

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@JReinhold JReinhold self-assigned this Jul 11, 2023
@JReinhold JReinhold added patch:yes Bugfix & documentation PR that need to be picked to main branch build Internal-facing build tooling & test updates labels Jul 11, 2023
@JReinhold
Copy link
Copy Markdown
Contributor Author

Superseded by #23335

@JReinhold JReinhold closed this Jul 11, 2023
@stof stof deleted the fix-danger-patch branch August 2, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates patch:yes Bugfix & documentation PR that need to be picked to main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant