CI: Introduce ci:normal label#23335
Merged
Merged
Conversation
Co-authored-by: Kasper Peulen <kasperpeulen@gmail.com>
4b5be7e to
0a58cc6
Compare
e6dac94 to
d1473ec
Compare
JReinhold
requested changes
Jul 10, 2023
6cba4f6 to
553eedb
Compare
553eedb to
f306128
Compare
Contributor
Author
|
@yannbf Could you also take a look? |
ndelangen
reviewed
Jul 10, 2023
Contributor
Author
|
@JReinhold Could you take another look? |
fd8233d to
bc2114c
Compare
Contributor
Author
|
@JReinhold One last review. I think now everything is in place :) |
5 tasks
0c11104 to
bbc275f
Compare
Member
|
@valentinpalkovic I'm guessing this PR is superseded and can be closed? |
This was referenced Jul 13, 2023
Closed
ci:normal label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23278
What I did
I have introduced the
ci:normallabel, which has to be applied to PRs to trigger a normal CircleCI run with a basic set of sandboxes.How to test
ci:daily,ci:mergedandci:normalone after another on this pr and see, whether the appropriate circleci job is started (I think this does not work, since the github action file is take fromnextinstead of this branch)Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]