Skip to content

Build: Fix workflow link in release PR description #23116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JReinhold merged 1 commit into from
Jun 23, 2023
Merged

Build: Fix workflow link in release PR description #23116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/release/generate-pr-description.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import chalk from 'chalk';
import program from 'commander';
import { z } from 'zod';
import dedent from 'ts-dedent';
import semver from 'semver';
import { setOutput } from '@actions/core';
import type { Change } from './utils/get-changes';
import { getChanges, LABELS_BY_IMPORTANCE, RELEASED_LABELS } from './utils/get-changes';
Expand Down Expand Up @@ -140,6 +141,9 @@ export const generateReleaseDescription = ({
changelogText: string;
manualCherryPicks?: string;
}): string => {
const workflow = semver.prerelease(nextVersion) ? 'prepare-prerelease' : 'prepare-patch-release';
const workflowUrl = `https://github.com/storybookjs/storybook/actions/workflows/${workflow}.yml`;

return (
dedent`This is an automated pull request that bumps the version from \`${currentVersion}\` to \`${nextVersion}\`.
Once this pull request is merged, it will trigger a new release of version \`${nextVersion}\`.
Expand Down Expand Up @@ -168,7 +172,7 @@ export const generateReleaseDescription = ({

${manualCherryPicks || ''}

If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with [this workflow](https://github.com/storybookjs/storybook/actions/workflows/prepare-prerelease.yml) and wait for it to finish. It will wipe your progress in this to do, which is expected.
If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with [this workflow](${workflowUrl}) and wait for it to finish. It will wipe your progress in this to do, which is expected.

When everything above is done:
- Merge this PR
Expand Down
Loading