Skip to content

Build: Fix workflow link in release PR description#23116

Merged
JReinhold merged 1 commit into
nextfrom
shilman/fix-release-url
Jun 23, 2023
Merged

Build: Fix workflow link in release PR description#23116
JReinhold merged 1 commit into
nextfrom
shilman/fix-release-url

Conversation

@shilman
Copy link
Copy Markdown
Member

@shilman shilman commented Jun 17, 2023

Closes N/A

What I did

The current release PR description points to the prerelease PR description regardless of whether the PR is a prerelease or a patch. This fixes it.

How to test

Currently untested.

  • Run from CLI?
  • Merge & re-run a patch release?

@shilman shilman added the build Internal-facing build tooling & test updates label Jun 17, 2023
@shilman shilman requested a review from JReinhold June 17, 2023 09:45
Copy link
Copy Markdown
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. ❤️

@JReinhold JReinhold added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 18, 2023
@JReinhold
Copy link
Copy Markdown
Contributor

@shilman changes to release tooling generally always needs the patch label as well, since the patch workflow runs from main. This means that the changes also won't take effect until a patch has been done, unless we do the cherry picking manually.

@JReinhold JReinhold merged commit 3fb9ab3 into next Jun 23, 2023
@JReinhold JReinhold deleted the shilman/fix-release-url branch June 23, 2023 11:01
@github-actions github-actions Bot mentioned this pull request Jun 23, 2023
12 tasks
JReinhold added a commit that referenced this pull request Jun 23, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
@github-actions github-actions Bot mentioned this pull request Jun 23, 2023
18 tasks
JReinhold added a commit that referenced this pull request Jun 23, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
JReinhold added a commit that referenced this pull request Jun 23, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
JReinhold added a commit that referenced this pull request Jun 23, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
JReinhold added a commit that referenced this pull request Jun 23, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
JReinhold added a commit that referenced this pull request Jun 24, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
JReinhold added a commit that referenced this pull request Jun 26, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
JReinhold added a commit that referenced this pull request Jun 26, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
JReinhold added a commit that referenced this pull request Jun 27, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
JReinhold added a commit that referenced this pull request Jun 27, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
JReinhold added a commit that referenced this pull request Jun 27, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
JReinhold added a commit that referenced this pull request Jun 27, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
@JReinhold JReinhold added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 27, 2023
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants