Skip to content

Release tooling: Give the full commit hash to the github API #23046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kasperpeulen merged 1 commit into from
Jun 13, 2023
Merged

Release tooling: Give the full commit hash to the github API #23046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/release/utils/get-github-info.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ function makeQuery(repos: ReposWithCommitsAndPRsToFetch) {
}
mergeCommit {
commitUrl
abbreviatedOid
oid
}
}`
)
Expand Down Expand Up @@ -285,11 +285,11 @@ export async function getPullInfoFromPullRequest(request: {
user: user ? user.login : null,
id: null,
pull: request.pull,
commit: commit ? commit.abbreviatedOid : null,
commit: commit ? commit.oid : null,
title: title || null,
labels: data ? (data.labels.nodes || []).map((label: { name: string }) => label.name) : null,
links: {
commit: commit ? `[\`${commit.abbreviatedOid}\`](${commit.commitUrl})` : null,
commit: commit ? `[\`${commit.oid}\`](${commit.commitUrl})` : null,
pull: `[#${request.pull}](https://github.com/${request.repo}/pull/${request.pull})`,
user: user ? `[@${user.login}](${user.url})` : null,
},
Expand Down
4 changes: 2 additions & 2 deletions scripts/release/utils/get-unpicked-prs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export async function getUnpickedPRs(baseBranch: string, verbose?: boolean): Pro
title
baseRefName
mergeCommit {
abbreviatedOid
oid
}
labels(first: 20) {
nodes {
Expand Down Expand Up @@ -55,7 +55,7 @@ export async function getUnpickedPRs(baseBranch: string, verbose?: boolean): Pro
id: node.id,
branch: node.baseRefName,
title: node.title,
mergeCommit: node.mergeCommit.abbreviatedOid,
mergeCommit: node.mergeCommit.oid,
labels: node.labels.nodes.map((l: any) => l.name),
}));

Expand Down
Loading