Skip to content

Release tooling: Give the full commit hash to the github API#23046

Merged
kasperpeulen merged 1 commit into
nextfrom
kasper/use-full-oid
Jun 13, 2023
Merged

Release tooling: Give the full commit hash to the github API#23046
kasperpeulen merged 1 commit into
nextfrom
kasper/use-full-oid

Conversation

@kasperpeulen

@kasperpeulen kasperpeulen commented Jun 13, 2023

Copy link
Copy Markdown
Member

What I did

Use the full commit hash for the github API, as it returns null with the short one sometimes (might be a clash??)

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kasperpeulen kasperpeulen added build Internal-facing build tooling & test updates patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 13, 2023
@kasperpeulen kasperpeulen force-pushed the kasper/use-full-oid branch from f89b77d to b450706 Compare June 13, 2023 12:59
@kasperpeulen kasperpeulen merged commit de18fcc into next Jun 13, 2023
@kasperpeulen kasperpeulen deleted the kasper/use-full-oid branch June 13, 2023 12:59
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 13, 2023
kasperpeulen added a commit that referenced this pull request Jun 13, 2023
@kasperpeulen
Merge pull request #23046 from storybookjs/kasper/use-full-oid
1ca9621 
Release tooling: Give the full commit hash to the github API
@github-actions github-actions Bot mentioned this pull request Jun 13, 2023
Merged
42 tasks
@shilman shilman removed the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 14, 2023
@github-actions github-actions Bot mentioned this pull request Jun 14, 2023
Merged
69 tasks
@JReinhold JReinhold added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 15, 2023
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shilman shilman shilman approved these changes

@JReinhold JReinhold Awaiting requested review from JReinhold

Assignees

No one assigned

Labels

build Internal-facing build tooling & test updates patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kasperpeulen @shilman @ndelangen @JReinhold