Addon-docs: Include decorators by default in source decorators#21902
Merged
Conversation
7 tasks
shilman
added
the
patch:yes
This was referenced Apr 5, 2023
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Apr 6, 2023
…e-exclude-decorators Addon-docs: Include decorators by default in source decorators
4 tasks
8 tasks
ndelangen
removed
the
patch:yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21900
What I did
Partially reverted #21722. There were some other fixes in there that I didn't touch.
We set
docs.source.excludeDecoratorstotruein order to avoid #21649 (not fix it).However, this completely breaks Storybook in the case when the story requires a decorator to be present, as is the case with the repro in #21900.
We'll need to come up with a proper fix to #21649.
How to test
See repro in #21900