Docs: Exclude decorators by default from source#21722
Merged
Merged
Conversation
Member
Author
|
We also might want to consider doing this for React only, as I think that's the only place the issue likely happens (see #21649 (comment)). However, I think it's reasonable to exclude decorators by default everywhere. |
tmeasday
commented
Mar 22, 2023
valentinpalkovic
approved these changes
Mar 22, 2023
shilman
approved these changes
Mar 22, 2023
It was returning different rendered code depending on what it was extracting source for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Due to reordering in #21182 the source decorator comes before any user decorator in
preview.js. This means that we commonly trigger the bug in #21649.Really it was a bug that was fixed by #21182 that the user's decorators weren't visible in the source by default given we weren't excluding them.
So it makes more sense to default this to true and people can opt out in cases where they want to show the decorator.
How to test
Add the following to a React sandbox's
preview.tsx:Then check the source block of a story:
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]