Skip to content

try/catch package.json resolve - fixes #10955 #11023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndelangen merged 5 commits into from
Jun 4, 2020
Merged

try/catch package.json resolve - fixes #10955 #11023

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0738560
try/catch package.json resolve - fixes #10955
MarkLyck Jun 2, 2020
30ebdd4
Merge branch 'next' into pr/MarkLyck/11023
ndelangen Jun 4, 2020
4a717a1
FIX linting
ndelangen Jun 4, 2020
836e197
ADD warning
ndelangen Jun 4, 2020
b8a7f52
FIX logger reference
ndelangen Jun 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions lib/core/src/server/manager/manager-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import fs from 'fs-extra';
import findUp from 'find-up';
import resolveFrom from 'resolve-from';

import { logger } from '@storybook/node-logger';

import loadPresets from '../presets';
import loadCustomPresets from '../common/custom-presets';
import { typeScriptDefaults } from '../config/defaults';
Expand All @@ -15,12 +17,17 @@ const getAutoRefs = async (options) => {

const list = await Promise.all(
Object.keys({ ...dependencies, ...devDependencies }).map(async (d) => {
const l = resolveFrom(directory, path.join(d, 'package.json'));
try {
const l = resolveFrom(directory, path.join(d, 'package.json'));

const { storybook, name } = await fs.readJSON(l);
const { storybook, name } = await fs.readJSON(l);

if (storybook?.url) {
return { id: name, ...storybook };
if (storybook?.url) {
return { id: name, ...storybook };
}
} catch {
logger.warn(`unable to find package.json for ${d}`);
return undefined;
}
return undefined;
})
Expand Down