try/catch package.json resolve - fixes #10955#11023
Merged
Merged
Conversation
shilman
requested changes
Jun 3, 2020
Member
shilman
left a comment
There was a problem hiding this comment.
Can we log an error in the catch block? @ndelangen can you take a close look at this? Also deepscan errors
Member
|
I'd like to understand why the JSON can not be found honestly. |
Member
|
Do you have a reproduction repo for me to inspect? |
ndelangen
approved these changes
Jun 4, 2020
|
We're not using rollup in our storybook, but it is a devdependency and storybook is throwing a warning of unable to find package.json for rollup when using version >= 2.3.4 |
|
I'm using rollup with SB and I get the same as @michaelbayday Seems like SB is trying to load the |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #10955
Issue:
What I did
Added safety around package.json resolve function.
How to test
Without this fix, it fails with the error mentioned in #10955