Remove duplicate types.ts file causing validation conflicts#62
Conversation
|
Co-authored-by: JReinhold <5678122+JReinhold@users.noreply.github.com>
Co-authored-by: JReinhold <5678122+JReinhold@users.noreply.github.com>
|
@copilot i dont know how I ended up with two types.ts files, thats pretty dumb. Delete the one in root mcp, so we only have src/types.ts and ensure that is up-to-date and that everything in the mcp package references that file. |
Co-authored-by: JReinhold <5678122+JReinhold@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #62 +/- ##
==========================================
+ Coverage 82.20% 82.56% +0.35%
==========================================
Files 15 15
Lines 843 843
Branches 159 162 +3
==========================================
+ Hits 693 696 +3
+ Misses 142 139 -3
Partials 8 8 ☔ View full report in Codecov by Sentry. |
Bundle ReportBundle size has no change ✅ |
commit: |
Co-authored-by: JReinhold <5678122+JReinhold@users.noreply.github.com>
Deleted the root Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
Already handled in #61 |
Component manifests were failing validation with
Invalid key: Expected "snippet" but received undefinedwhen examples lacked snippets (e.g., stories with render errors).The issue was caused by a duplicate
types.tsfile in the@storybook/mcppackage:/packages/mcp/types.ts(root) - outdated duplicate file with stricter validation/packages/mcp/src/types.ts- comprehensive, up-to-date file with optional snippet supportFiles in
src/were importing from../types.ts, which created ambiguity about which schema was being used.Changes
packages/mcp/types.tsfile entirelysrc/types.tswhich already had:StorybookContextinterface withmanifestProviderand handler callbacksThe
src/types.tsschema was already complete and up-to-date with all necessary features. The format-manifest utility already handles missing snippets gracefully by skipping them during rendering.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.