Add dynamic tools to Available Toolsets by yannbf · Pull Request #265 · storybookjs/mcp

yannbf · 2026-06-02T14:08:23Z

This adds dynamic tools which were not available in the template, as it was only adding static tools.

changeset-bot · 2026-06-02T14:08:29Z

🦋 Changeset detected

Latest commit: 902debf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@storybook/addon-mcp	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2026-06-02T14:09:03Z

npx https://pkg.pr.new/storybookjs/mcp/@storybook/addon-mcp@265

npx https://pkg.pr.new/storybookjs/mcp/@storybook/mcp@265

npx https://pkg.pr.new/storybookjs/mcp/@storybook/mcp-proxy@265

commit: 902debf

codecov · 2026-06-02T14:09:20Z

Bundle Report

Changes will increase total bundle size by 31.73kB (19.52%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name	Size	Change
@storybook/addon-mcp-esm*	114.53kB	31.73kB (38.31%) ⬆️⚠️

ℹ️ *Bundle size includes cached data from a previous commit

Affected Assets, Files, and Routes:

view changes for bundle: @storybook/addon-mcp-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`preset.js`	31.73kB	114.53kB	38.31% ⚠️

Files in preset.js:

./src/preset.ts → Total Size: 6.47kB
./src/template.html → Total Size: 5.47kB
./src/mcp-handler.ts → Total Size: 5.7kB
./src/utils/get-tool-availability.ts → Total Size: 1.41kB
./src/instructions/build-server-instructions.ts → Total Size: 2.11kB

codecov · 2026-06-02T14:09:38Z

Codecov Report

❌ Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.03%. Comparing base (f56500d) to head (902debf).
⚠️ Report is 11 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
packages/addon-mcp/src/preset.ts	75.00%	0 Missing and 4 partials ⚠️
packages/addon-mcp/src/mcp-handler.ts	75.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   78.61%   79.03%   +0.42%     
==========================================
  Files          62       63       +1     
  Lines        1800     1808       +8     
  Branches      500      510      +10     
==========================================
+ Hits         1415     1429      +14     
+ Misses        218      213       -5     
+ Partials      167      166       -1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

netlify · 2026-06-03T09:18:38Z

✅ Deploy Preview for storybook-mcp-self-host-example canceled.

Name	Link
🔨 Latest commit	`902debf`
🔍 Latest deploy log	https://app.netlify.com/projects/storybook-mcp-self-host-example/deploys/6a211d851a3d700008711060

Copilot

Pull request overview

This PR updates the @storybook/addon-mcp /mcp landing page so it surfaces tools that are conditionally available at runtime (change-detection, dependency-graph, and review-related tools), and centralizes the tool-availability gating logic so the MCP server and landing page derive availability from the same helper.

Changes:

Add a shared getToolAvailability() helper to compute runtime gates (dependency graph support, change detection enablement, and review availability).
Expand the /mcp landing page “Available Toolsets” list to include get-changed-stories, get-stories-by-component, display-review, and get-documentation-for-story, with per-tool enabled/disabled badges + explanatory notices.
Update MCP server initialization to reuse the shared availability helper (reducing drift between registered tools and landing-page claims).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`packages/mcp-proxy/src/types/record/v1.ts`	Reorders Valibot pipe validators for `pid`/`port` numeric fields.
`packages/addon-mcp/src/utils/get-tool-availability.ts`	New shared helper returning a single “source of truth” for tool gating.
`packages/addon-mcp/src/tools/get-stories-by-component.ts`	Reorders Valibot pipe validators for `maxDistance`.
`packages/addon-mcp/src/template.html`	Adds the newly surfaced tool names and new placeholders for per-tool badges/notices.
`packages/addon-mcp/src/preset.ts`	Uses `getToolAvailability()` and fills new HTML placeholders (badges + notices).
`packages/addon-mcp/src/preset.test.ts`	Adds a test ensuring the landing page lists the new tools and no `{{...}}` placeholders leak.
`packages/addon-mcp/src/mcp-handler.ts`	Switches to `getToolAvailability()` so server registration and landing page share gating logic.
`.changeset/spotty-toolsets-surface.md`	Changeset documenting the landing page surfacing and the shared gating helper.

This reverts commit 3e0e4de.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

 import { STORYBOOK_MCP_PROXY_HEADER } from './auth/index.ts';
 import * as mcpHandlerModule from './mcp-handler.ts';
 import * as runStoryTests from './tools/run-story-tests.ts';
+import * as changeDetection from './utils/change-detection.ts';



+// Lets us flip `@storybook/addon-review` presence so the review tool's gate can be exercised.
+// Keep the real exports (e.g. `normalizeStoryPath`) so unrelated tools still register.
+const { mockGetAddonNames } = vi.hoisted(() => ({
+	mockGetAddonNames: vi.fn(() => [] as string[]),
+}));
+vi.mock('storybook/internal/common', async (importActual) => ({
+	...(await importActual<typeof import('storybook/internal/common')>()),
+	loadMainConfig: vi.fn().mockResolvedValue({}),
+	getAddonNames: () => mockGetAddonNames(),
+}));
+


+	/** Dev-server builder supports the dependency-graph API. Gates `get-stories-by-component`. */
+	dependencyGraphSupported: boolean;


yannbf and others added 2 commits June 2, 2026 16:38

add dynamic tools to Available Toolsets

7c96f50

fix: apply oxfmt formatting to dynamic-tools files

ca1596f

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

yannbf force-pushed the yann/update-available-toolsets branch from 6b48934 to ca1596f Compare June 2, 2026 14:40

Base automatically changed from yann/story-discovery to main June 3, 2026 08:53

JReinhold requested changes Jun 3, 2026

View reviewed changes

Comment thread packages/addon-mcp/src/utils/get-tool-availability.ts

temp fix

3e0e4de

Copilot AI review requested due to automatic review settings June 3, 2026 09:18

Copilot started reviewing on behalf of yannbf June 3, 2026 09:18 View session

Copilot AI reviewed Jun 3, 2026

View reviewed changes

Comment thread packages/addon-mcp/src/preset.ts

yannbf added 3 commits June 3, 2026 12:49

Revert "temp fix"

d6f1729

This reverts commit 3e0e4de.

address review feedback

abaf32b

Merge branch 'main' into yann/update-available-toolsets

e93b2f4

yannbf requested review from JReinhold and Copilot June 3, 2026 10:55

Copilot started reviewing on behalf of yannbf June 3, 2026 10:55 View session

Copilot AI reviewed Jun 3, 2026

View reviewed changes

JReinhold approved these changes Jun 3, 2026

View reviewed changes

ghengeveld approved these changes Jun 3, 2026

View reviewed changes

Comment thread packages/addon-mcp/src/mcp-handler.ts Outdated

yannbf added 3 commits June 4, 2026 08:28

improve naming consistency

2cb2c99

add tests

f0b2000

format

1744cad

Copilot AI review requested due to automatic review settings June 4, 2026 06:36

Copilot started reviewing on behalf of yannbf June 4, 2026 06:36 View session

update release note

902debf

yannbf merged commit fb37940 into main Jun 4, 2026
14 checks passed

yannbf deleted the yann/update-available-toolsets branch June 4, 2026 06:40

storybook-app-bot Bot mentioned this pull request Jun 4, 2026

Version Packages #270

Closed

Copilot AI reviewed Jun 4, 2026

View reviewed changes

storybook-app-bot Bot mentioned this pull request Jun 5, 2026

Version Packages #275

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add dynamic tools to Available Toolsets#265

Add dynamic tools to Available Toolsets#265
yannbf merged 10 commits into
mainfrom
yann/update-available-toolsets

yannbf commented Jun 2, 2026

Uh oh!

changeset-bot Bot commented Jun 2, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Jun 2, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jun 2, 2026 •

edited

Loading

Assets Changed:

Uh oh!

codecov Bot commented Jun 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

netlify Bot commented Jun 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		/** Dev-server builder supports the dependency-graph API. Gates `get-stories-by-component`. */
		dependencyGraphSupported: boolean;

Conversation

yannbf commented Jun 2, 2026

Uh oh!

changeset-bot Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

codecov Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

netlify Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for storybook-mcp-self-host-example canceled.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

changeset-bot Bot commented Jun 2, 2026 •

edited

Loading

pkg-pr-new Bot commented Jun 2, 2026 •

edited

Loading

codecov Bot commented Jun 2, 2026 •

edited

Loading

codecov Bot commented Jun 2, 2026 •

edited

Loading

netlify Bot commented Jun 3, 2026 •

edited

Loading