Makes it available even in versions below 9.12.0#19
Closed
penicillin0 wants to merge 3 commits into
Closed
Conversation
🦋 Changeset detectedLatest commit: 2f0216c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
thank you for this! this was originally the direction we wanted to go with, but instead we've opted to drop support for v8 entirely, and soon also require v10.1 as we want to depend on upcoming features in Storybook core. Therefore I'm closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
close: #14
Background
This mcp was unavailable in certain versions. (See the Related Issue for details.)
from this PR( storybookjs/storybook#31557 )
Upon my investigation, I discovered that storybook's v9.12.0 and later versions had added several methods to the logger, including
debug.This caused issues for users still using versions below 9.12.0, as the functionality did not work properly.
What to do
To resolve this, I created a wrapper function that evaluates
logger.debugat runtime and falls back tologger.infoif the method is not available.I then modified all instances of
logger.debugto use this wrapper function instead.