Add support for AWS custom VPC

[aswinsuryan]

Add support for AWS custom VPC

[tpantelis]

Unfortunately we can't bump submariner dependencies to 0.19 yet due to the K8s bump to 0.31. The github.com/openshift/library-go needs to bump first, which is pending with openshift/library-go#1771.

# github.com/openshift/library-go/pkg/serviceability
/go/pkg/mod/github.com/openshift/library-go@v0.0.0-20240124134907-4dfbf6bc7b11/pkg/serviceability/panic.go:54:65: cannot use crashOnDelay(delayDuration, delayDurationString) (value of type func(interface{})) as func(context.Context, interface{}) value in argument to append
# k8s.io/component-base/metrics/testutil
/go/pkg/mod/k8s.io/component-base@v0.31.0/metrics/testutil/metrics.go:73:59: undefined: expfmt.NewFormat

[tpantelis]

This error:

# k8s.io/component-base/metrics/testutil
/go/pkg/mod/k8s.io/component-base@v0.31.0/metrics/testutil/metrics.go:73:59: undefined: expfmt.NewFormat

is b/c we're pinning github.com/prometheus/common to v0.47.0 but k8s.io/component-base needs v0.55.0. We should be able to remove the pin now.

[aswinsuryan]

Unfortunately we can't bump submariner dependencies to 0.19 yet due to the K8s bump to 0.31. The github.com/openshift/library-go needs to bump first, which is pending with openshift/library-go#1771.

# github.com/openshift/library-go/pkg/serviceability
/go/pkg/mod/github.com/openshift/library-go@v0.0.0-20240124134907-4dfbf6bc7b11/pkg/serviceability/panic.go:54:65: cannot use crashOnDelay(delayDuration, delayDurationString) (value of type func(interface{})) as func(context.Context, interface{}) value in argument to append
# k8s.io/component-base/metrics/testutil
/go/pkg/mod/k8s.io/component-base@v0.31.0/metrics/testutil/metrics.go:73:59: undefined: expfmt.NewFormat

so we ill have to try get this change in just for 0.16?

[sonarqubecloud]

Quality Gate failed

Failed conditions
6.2% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

[tpantelis]

/override ci/prow/sonarcloud

[openshift-ci]

@tpantelis: Overrode contexts on behalf of tpantelis: ci/prow/sonarcloud

Details

In response to this:

/override ci/prow/sonarcloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tpantelis]

/override "SonarCloud Code Analysis"

[openshift-ci]

@tpantelis: Overrode contexts on behalf of tpantelis: SonarCloud Code Analysis

Details

In response to this:

/override "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tpantelis]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tpantelis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [tpantelis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment