Skip to content

WRKLDS-1449: bump(k8s): update k8s.io/* dependencies to v1.31.1 #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 5 commits into from
Oct 1, 2024
Merged

WRKLDS-1449: bump(k8s): update k8s.io/* dependencies to v1.31.1 #1771

openshift-merge-bot merged 5 commits into from
Oct 1, 2024

Conversation

@atiratree
Copy link
Member

@atiratree atiratree commented Aug 5, 2024

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2024
@openshift-ci openshift-ci bot requested review from deads2k and rcarrillocruz August 5, 2024 20:32
@atiratree atiratree changed the title [WIP] bump(k8s): update k8s.io/* dependencies to v1.31.0 [WIP] WRKLDS-1449: bump(k8s): update k8s.io/* dependencies to v1.31.0 Aug 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 7, 2024 •
edited by openshift-ci bot
Loading

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.18" instead.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 7, 2024
@skitt skitt mentioned this pull request Aug 19, 2024
Closed
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2024
@gallettilance
Copy link

gallettilance commented Sep 10, 2024

Is there a reason this is still in WIP?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2024
@atiratree
Copy link
Member Author

atiratree commented Sep 11, 2024 •
edited
Loading

the WIP is there until the dependencies have been merged: please see replace directives in go.mod

@gallettilance gallettilance mentioned this pull request Sep 11, 2024
Merged
@atiratree atiratree force-pushed the bump-1.31 branch 4 times, most recently from 785aaf8 to 9925541 Compare September 11, 2024 16:31
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2024
@atiratree atiratree changed the title [WIP] WRKLDS-1449: bump(k8s): update k8s.io/* dependencies to v1.31.0 [WIP] WRKLDS-1449: bump(k8s): update k8s.io/* dependencies to v1.31.1 Sep 20, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2024
@tpantelis tpantelis mentioned this pull request Sep 25, 2024
Merged
@tpantelis
Copy link

tpantelis commented Sep 25, 2024

Is there an approximate ETA for this PR to land? This is blocking the https://github.com/stolostron/submariner-addon repo from bumping other dependencies.

@atiratree
Copy link
Member Author

atiratree commented Sep 26, 2024

@tpantelis hopefully by the end of week, or beginning of the next week

@atiratree atiratree force-pushed the bump-1.31 branch 2 times, most recently from 0e57e77 to 1061c36 Compare September 26, 2024 18:18
@mzeevi
Copy link

mzeevi commented Oct 1, 2024

We're also looking for this to get merged, any updates?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2024
@atiratree atiratree changed the title [WIP] WRKLDS-1449: bump(k8s): update k8s.io/* dependencies to v1.31.1 WRKLDS-1449: bump(k8s): update k8s.io/* dependencies to v1.31.1 Oct 1, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2024
@atiratree
Copy link
Member Author

atiratree commented Oct 1, 2024

openshift/api#1983 openshift/client-go#291 have been merged today

next one is this PR

cc @gallettilance @tpantelis @mzeevi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

@atiratree: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

bertinatto
bertinatto reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 756adf2 into openshift:master Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bertinatto bertinatto bertinatto left review comments

@deads2k deads2k Awaiting requested review from deads2k

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

Assignees

@bertinatto bertinatto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@atiratree @openshift-ci-robot @gallettilance @tpantelis @mzeevi @bertinatto @openshift-merge-robot