[ACM-3650]: Adding KubeVirt as a provider for hosted control planes #4803
Conversation
davidvossel
left a comment
davidvossel
left a comment
There was a problem hiding this comment.
here's some preliminary feedback. i'll give this a more detailed look later this week.
davidvossel
left a comment
davidvossel
left a comment
There was a problem hiding this comment.
hey, here's some more detailed feedback. I know a lot of the content has been pulled from resources I wrote. Since this is official documentation, we need to mention OpenShift Virtualization as the product that we're supporting hosted control planes with. I tried to sort through that a bit. It's a bit tricky.
|
Thanks for your feedback, @davidvossel and @rokej! I made a few updates based on your comments. When you can, let me know what you think. |
|
I added a list of benefits to the introduction, based on this blog post: https://cloud.redhat.com/blog/effortlessly-and-efficiently-provision-openshift-clusters-with-openshift-virtualization |
davidvossel
left a comment
davidvossel
left a comment
There was a problem hiding this comment.
I made a couple of more minor comments. I think this is getting close
|
@davidvossel I made a few more updates based on your feedback. Let me know what you think when you can! |
|
@swopebrandi1 Do you have the bandwidth to peer review the new KubeVirt docs for hosted control planes sometime in the next week or so? David and Roke have already reviewed them. |
swopebe
left a comment
swopebe
left a comment
There was a problem hiding this comment.
I asked for a number of changes but will note here some that may apply in various places:
We usually pull out the command from the file that needs to be applied:
- Create a __ file similar to the following example, with the .... specification.
- Run the
oc -apply <fileto apply your ___ file.
(Sometimes they are together in these sections)
We remove extra stuff like EOF which is located in a few spots.
(There may be some formatting issues, which are usually caused by an extra asterisks. I cannot easily tell but will check as we get closer to final.)
|
Thanks, Brandi! I will take a look at your comments this afternoon. |
|
Hey @lahinson , the dev portion was merged. stolostron/console#2665 I used |
|
@chenz4027 That looks right to me. Thanks! |
|
Perfect, thanks @lahinson for the quick confirmation :) |
|
To do: Incorporate updates from https://github.com/openshift/hypershift/pull/2318/files |
davidvossel
left a comment
davidvossel
left a comment
There was a problem hiding this comment.
the content looks great. I left one comment about the formatting that i was unsure about
|
@swopebe When you're back from PTO, please take a look at the latest draft of the KubeVirt docs and let me know if we're ready to merge. Thank you! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: davidvossel, lahinson, swopebe The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thanks, Brandi! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: davidvossel, lahinson, swopebe The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
6 participants
This PR adds documentation to the hosted control planes section about using KubeVirt as a provider. This will be Technology Preview for MCE 2.3.
Related Jira task: https://issues.redhat.com/browse/ACM-3650