osflow rework #99
Merged
osflow rework #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s' and 'constraints'
Merged
stnolting
approved these changes
Jul 6, 2021
|
Wow! Thank you so much for all that work and effort! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extracted the commits from #98 which add ECP5 support but which are not specific about OrangeCrab. Then, I reworked the structure in
osflowfor reducing the board specific subdirectories, which might be misleading.setups/osflow/constraintsdirectory containing the PCF/LPF files for all boards.setups/osflow/BOARDNAME/Makefilewere renamed tosetups/osflow/boards/BOARDNAME.mk. ThoseBOARDNAME.mknow only contain the tasks which are specific to a board (such as a custom bitstream load command).setups/osflow/boards/index.mkandcommon.mk, which contain all the targets common to any board.As a result, now there is no
Makefileinsetups/osflow/**, making it explicit that those are all resources to be used from some other entrypoint (precisely,setups/examples/Makefile). See https://github.com/umarcor/neorv32/tree/osflow-rework/setups/osflow