Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCC Bus #98

Merged
merged 1 commit into from
Aug 17, 2019
Merged

RCC Bus #98

merged 1 commit into from
Aug 17, 2019

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Aug 15, 2019 •
edited
Loading

It is not breaking change.

@burrbull
Copy link
Member Author

cc @TheZoq2
cc @therealprof

therealprof
therealprof requested changes Aug 15, 2019
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good to me, but is also lacking CHANGELOG entry.

@burrbull
Copy link
Member Author

Done.

@therealprof
Copy link
Member

@TheZoq2 Would you mind lending me another pair of eyes here?

@TheZoq2
Copy link
Member

TheZoq2 commented Aug 15, 2019

Sure, I'll have a look at it after work in a few hours

@burrbull
Copy link
Member Author

ping @TheZoq2

TheZoq2
TheZoq2 approved these changes Aug 17, 2019
View reviewed changes
Copy link
Member

@TheZoq2 TheZoq2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, this looks good to me. Thanks!

@TheZoq2 TheZoq2 merged commit b1b1c87 into stm32-rs:master Aug 17, 2019
@burrbull burrbull deleted the bus branch August 17, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheZoq2 TheZoq2 TheZoq2 approved these changes

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burrbull @therealprof @TheZoq2