Add an example with RTIC. #27
Conversation
examples/ip_rtic.rs
Outdated
| static mut RX_RING: Option<[RingEntry<RxDescriptor>; 8]> = None; | ||
| static mut TX_RING: Option<[RingEntry<TxDescriptor>; 2]> = None; |
There was a problem hiding this comment.
Could you use the const constructors introduced in #22 ?
There was a problem hiding this comment.
I used them, but the problem is that they are not copy so they cannot be used like before. They could be generated by a macro call. Is this solution good enough? Or do you propose something else?
There was a problem hiding this comment.
Unfortunately, writing them out like that is required for now, at least until rust-lang/rust#49147 is solved. However, I think we export a type alias to help with that, RxRingEntry and TxRingEntry IIRC.
I think it's important to show this const option, without it you end up paying double the ram during initialization, and since those structs are quite large, it becomes required in some cases to avoid stack overflows.
examples/ip_rtic.rs
Outdated
| // HCLK must be at least 25MHz to use the ethernet peripheral | ||
| let clocks = rcc.cfgr.sysclk(32.mhz()).hclk(32.mhz()).freeze(); | ||
|
|
||
| writeln!(stdout, "Enabling ethernet...").unwrap(); |
There was a problem hiding this comment.
Why don't use log instead of writeln!(stdout) ? That way you save some code and a RTIC resource.
There was a problem hiding this comment.
I used the same thing used in the non-RTIC example for consistency, my code originally used defmt. What exactly do you mean by log? is there a Rust log backend for RTT?
There was a problem hiding this comment.
You already implemented log for semihosting, can't you just call log::info! (etc) instead of writeln! ?
There was a problem hiding this comment.
Oh, and about the defmt commented out code, maybe you could change it for log::error! ?
…f writes to semihosting's stdout.
|
Do you have an actually working example running on the F767 ? I'm not sure were in my setup things are broken, but I can't sniff a single thing with Wireshark with either your PR or any other example in the project that I tried to adapt to the F767. |
|
Yeah, I did. I was using the Nucleo board though. |
|
Have a look here: https://github.com/matoushybl/nucleo-playground |
|
Thanks! |
|
We've added an up-to-date and working RTIC + smoltcp example in #54 that compiles and runs on all supported MCUs. I'm fairly certain the example should run on nucleo boards with the Closing in favor of #54 |
This PR adapts the
ipexample to use RTIC. I have tested the code on a F767, but adapted it to the F4 as the original example uses. That means that it couldn't be tested as I do not have a Nucleo with an F4 at hand.