Make the creation of TxRingEntry and RxRingEntry const #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamgreig
approved these changes
Aug 29, 2020
|
Build succeeded: |
franeklubi
pushed a commit
to franeklubi/stm32-eth
that referenced
this pull request
Mar 22, 2022
22: Make the creation of TxRingEntry and RxRingEntry const r=adamgreig a=thalesfragoso This allow for people to create `RingEntry` on a const context, which saves a considerable amount of stack during initialization if having them in a `static`. I also left the non const `Default` implementations for compatibility and also because of rust-lang/rust#49147, which causes the creation of entries a bit cumbersome since `Aligned` isn't `Copy`, so users can use `default` on non const contexts if they want to. CC @adamgreig Co-authored-by: Thales Fragoso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow for people to create
RingEntryon a const context, which saves a considerable amount of stack during initialization if having them in astatic.I also left the non const
Defaultimplementations for compatibility and also because of rust-lang/rust#49147, which causes the creation of entries a bit cumbersome sinceAlignedisn'tCopy, so users can usedefaulton non const contexts if they want to.CC @adamgreig