Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapping Markdown file with reference link messes up the links #93

Closed
gCardinal opened this issue Jul 3, 2018 · 5 comments
Closed

Wrapping Markdown file with reference link messes up the links #93

gCardinal opened this issue Jul 3, 2018 · 5 comments

Comments

@gCardinal
Copy link

Say I have a list of links like so:

[1]: https://github.com/facebookincubator/create-react-app
[2]: https://github.com/Microsoft/TypeScript-React-Starter
[3]: https://github.com/facebook/react
[4]: https://github.com/reactjs/redux
[5]: https://github.com/gaearon/redux-thunk
[6]: https://github.com/yahoo/react-intl
[7]: https://github.com/reactjs/reselect
[8]: https://github.com/zinserjan/mocha-webpack
[9]: https://github.com/paularmstrong/normalizr

When I wrap this, I get:

[1]: https://github.com/facebookincubator/create-react-app [2]:
https://github.com/Microsoft/TypeScript-React-Starter [3]:
https://github.com/facebook/react [4]: https://github.com/reactjs/redux [5]:
https://github.com/gaearon/redux-thunk [6]: https://github.com/yahoo/react-intl
[7]: https://github.com/reactjs/reselect [8]:
https://github.com/zinserjan/mocha-webpack [9]:
https://github.com/paularmstrong/normalizr

Resulting in broken links.

@stkb
Copy link
Owner

stkb commented Dec 13, 2021

Hi, I'd missed this issue; it's a duplicate of #63.

This is fixed in the next version: you can download & install v1.16.0-beta.2 if you like. I tried rewrapping the file you linked and it all seemed to look fine.

(Technically it doesn't yet follow the specs for link reference definitions exactly but it should be fine unless you "try to break it".)

@stkb stkb added the in pre-release version Is in pre-release version but not in stable yet label Dec 13, 2021
stkb added a commit that referenced this issue Jan 14, 2022
- New architecture (still WIP) with performance increase.
- Markdown: new parser that fixes many small bugs (inc #288), as well as
  supporting:
  - Front matter header (#277, #294)
  - Link reference definitions (#63, #93)
  - Footnotes (#188)
- ReStructuredText support (standalone & for Python, almost complete)
  (#88).
- Julia: support `#= ... =#` block comments (#302)
- Visual Studio: Wrap to rulers generated from .editorconfig by the
  Editor Guidelines extension (thereby indirectly supporting
  .editorconfig) (#300).
@stkb
Copy link
Owner

stkb commented Jan 14, 2022

Fixed in v1.16.0

@stkb stkb closed this as completed Jan 14, 2022
@stkb stkb removed the in pre-release version Is in pre-release version but not in stable yet label Jan 14, 2022
@jsumners
Copy link

@stkb thanks for the release. Sorry I never tested the beta. I just didn't ever find the time.

@vilicvane
Copy link

Hi @stkb, is it viable to make this work in markdown in comment? Currently it still messes link references in comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants