Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown footnotes are not wrapped correctly #188

Closed
zandaleph opened this issue Apr 26, 2020 · 2 comments
Closed

Markdown footnotes are not wrapped correctly #188

zandaleph opened this issue Apr 26, 2020 · 2 comments

Comments

@zandaleph
Copy link

Currently, an overlong footnote like so:

[^1]: I have a funny story about this that I am not quite prepared to tell at the moment but want to tell someday.

is not rewrapped, violating an 80 character limit. Manually rewrapping to

[^1]: I have a funny story about this that I am not quite prepared to tell at
  the moment but want to tell someday.

which follows guidelines for long footnotes, is incorrectly rewrapped to

[^1]:

  I have a funny story about this that I am not quite prepared to tell at
  the moment but want to tell someday.

which is rendered as an empty footnotes and places an unwanted paragraph in the main text.

I would be able to work around this bug by simply allowing long-lined footnotes if I only had simple footnotes, but unfortunately more complicated footnotes, like this one from the footnote documentation above, are always mangled by rewrap.

[^bignote]: Here's one with multiple paragraphs and code.

    Indent paragraphs to include them in the footnote.

    `{ my code }`

    Add as many paragraphs as you like.

Would it be possible to add support for long footnotes and fix this bug? Thank you.

@rossmacarthur
Copy link

Problem the same as #63

@stkb stkb added the duplicate label May 14, 2020
@stkb
Copy link
Owner

stkb commented May 14, 2020

Closing as duplicate of #63. I did try to fix it but found I basically had to rewrite the markdown parser to fix that (and other) bugs, which is still a WIP

@stkb stkb closed this as completed May 14, 2020
stkb added a commit that referenced this issue Nov 29, 2021
stkb added a commit that referenced this issue Dec 19, 2021
stkb added a commit that referenced this issue Jan 14, 2022
- New architecture (still WIP) with performance increase.
- Markdown: new parser that fixes many small bugs (inc #288), as well as
  supporting:
  - Front matter header (#277, #294)
  - Link reference definitions (#63, #93)
  - Footnotes (#188)
- ReStructuredText support (standalone & for Python, almost complete)
  (#88).
- Julia: support `#= ... =#` block comments (#302)
- Visual Studio: Wrap to rulers generated from .editorconfig by the
  Editor Guidelines extension (thereby indirectly supporting
  .editorconfig) (#300).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants