Skip to content

fix: some page properties have optional values #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

fix: some page properties have optional values #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pydantic_api/notion/models/objects/properties/page_property.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ class DateProperty(BasePageProperty):
"""A page property of type 'date'."""

type: Literal["date"] = "date"
date: DateValue = Field(
date: Optional[DateValue] = Field(
...,
description="The value of the date property, including start and optional end.",
)
Expand Down Expand Up @@ -217,7 +217,7 @@ class MultiSelectProperty(BasePageProperty):
# number: Refer to https://developers.notion.com/reference/page-property-values#number
class NumberProperty(BasePageProperty):
type: Literal["number"] = "number"
number: float
number: Optional[float] = None


# people: Refer to https://developers.notion.com/reference/page-property-values#people
Expand Down Expand Up @@ -359,7 +359,7 @@ def new_text(
# select: Refer to https://developers.notion.com/reference/page-property-values#select
class SelectProperty(BasePageProperty):
type: Literal["select"] = "select"
select: SelectOption
select: Optional[SelectOption] = None

@classmethod
def new(
Expand Down