Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes unnecessary copy of print_to_string_internal and incorrect prost link in readme.md #684

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

vaikzs
Copy link
Contributor

@vaikzs vaikzs commented Oct 2, 2023

@stepancheg Please kindly review.
fixes #680
fixes #669

@vaikzs vaikzs changed the title minor fix to remove to_string() minor fixes Oct 2, 2023
@vaikzs vaikzs changed the title minor fixes Fixes https://github.com/stepancheg/rust-protobuf/issues/680 and https://github.com/stepancheg/rust-protobuf/issues/669 Oct 16, 2023
@vaikzs vaikzs changed the title Fixes https://github.com/stepancheg/rust-protobuf/issues/680 and https://github.com/stepancheg/rust-protobuf/issues/669 Fixes #680 and #669 Oct 16, 2023
@vaikzs vaikzs changed the title Fixes #680 and #669 Fixes unnecessary copy of print_to_string_internal Oct 16, 2023
@vaikzs vaikzs changed the title Fixes unnecessary copy of print_to_string_internal Fixes unnecessary copy of print_to_string_internal and incorrect prost link in readme.md Oct 16, 2023
@vaikzs
Copy link
Contributor Author

vaikzs commented Nov 14, 2023

@stepancheg just following up with this. Let me know if there is anything associated to be done

@stepancheg stepancheg merged commit 4f5ad19 into stepancheg:master Nov 14, 2023
9 of 10 checks passed
@stepancheg
Copy link
Owner

Thanks! Project is not maintained well now, and in process of transfer to another organization, but it will take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary copy in print_to_string_internal Wrong link to Prost in README
2 participants