Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary copy in print_to_string_internal #680

Closed
gmoshkin opened this issue Aug 31, 2023 · 0 comments · Fixed by #684
Closed

Unnecessary copy in print_to_string_internal #680

gmoshkin opened this issue Aug 31, 2023 · 0 comments · Fixed by #684

Comments

@gmoshkin
Copy link

In print_to_string_internal the newly constructed string is copied for no reason

rust-protobuf/protobuf/src/text_format/print.rs

Line 170 in 4bfb5c3

r.to_string()

vaikzs pushed a commit to vaikzs/rust-protobuf that referenced this issue Oct 2, 2023
fix: fixes issue stepancheg#680
2fa2b0d
@vaikzs vaikzs mentioned this issue Oct 2, 2023
Merged
stepancheg pushed a commit that referenced this issue Nov 14, 2023
@stepancheg
fix: fixes issue #680
8e3b821
stepancheg pushed a commit that referenced this issue Dec 5, 2023
@stepancheg
fix: fixes issue #680
692f0a4
akhramov pushed a commit to cognitedata/rust-protobuf that referenced this issue Jan 5, 2024
@akhramov
fix: fixes issue stepancheg#680
4e9211b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@gmoshkin