Skip to content

Fix account switcher flicker during multi-account menu refresh - #946

Closed
kubahasek wants to merge 1 commit into
steipete:mainfrom
kubahasek:main
Closed

Fix account switcher flicker during multi-account menu refresh#946
kubahasek wants to merge 1 commit into
steipete:mainfrom
kubahasek:main

Conversation

@kubahasek

Copy link
Copy Markdown
Contributor

Fixes an issue where the Menubar app flickers when there is more than one account added to a provider

steipete added a commit that referenced this pull request May 14, 2026
Fixes #944.

Refs #946.

Co-authored-by: Jakub Hašek <kubahasek@users.noreply.github.com>
@steipete

Copy link
Copy Markdown
Owner

Thanks @kubahasek, this was the right bug class. I landed the maintainer-side fix on main in aebe1c91 with your commit credited via Co-authored-by.

I changed the shape a bit: instead of only disabling animation around rebuilds, switcher-triggered rebuilds are deferred until after the account-selection action returns, and token-account switcher state is now tracked like the Codex switcher so smart menu refreshes do not drop into unnecessary full rebuilds.

Verified with focused switcher regressions, full swift test, and make check. Closing this PR since the fix is now on main.

@steipete steipete closed this May 14, 2026
steipete added a commit that referenced this pull request May 14, 2026
* Improve Kiro credits UX

* Add provider changelog links

* Fix changelog menu test

* feat: gate provider changelog links behind setting

* Address Kiro review feedback

* Polish Kiro credit detail styling

* fix: repair stale managed Codex account removal

* fix: handle Claude enterprise web accounts (#941)

Fixes Claude Enterprise/organization web accounts by tolerating null session-window usage and exposing an optional organization ID field for Claude token accounts.

Local verification:
- swift test --filter 'ClaudeWebEnterpriseUsageTests|ProvidersPaneCoverageTests|ClaudeUsageTests'
- make check

Co-authored-by: Claude <noreply@anthropic.com>

* docs: update changelog for Claude enterprise fix

* fix: handle quota and usage edge cases

* Rebalance Kimi provider icon (#912)

* Add zh-Hans translations for Claude peak hour labels (#921)

* docs: update changelog for recent contributor fixes

* Add Tahoe menu bar visibility guidance

Co-authored-by: Piotr Durlej <pdurlej@users.noreply.github.com>

* Coalesce historical pace reset buckets

Co-authored-by: zhulijin1991 <zhulijin1991@users.noreply.github.com>

* Add Codex priority cost pricing

Co-authored-by: Bryan Font <bfont@me.com>

* fix: parse Claude web spend limits

* fix: refresh Gemini credentials without access token

* refactor: split Claude web extra usage helpers

* fix: defer account switcher menu rebuilds

Fixes #944.

Refs #946.

Co-authored-by: Jakub Hašek <kubahasek@users.noreply.github.com>

* docs: fix changelog spacing

* fix: handle unavailable Codex limits gracefully

* docs: update unreleased changelog

* fix: repair update and account menu paths

Co-authored-by: Radek Sienkiewicz <mail@velvetshark.com>

* fix: handle account-scoped usage and menu login bugs

* Add Antigravity account switching (#937)

* Add Antigravity account switching

* Force Antigravity account chooser

* Persist Antigravity selected account updates

* docs: add Antigravity account switching changelog

---------

Co-authored-by: thiagocaltoe <thiago12_fera@hotmail.com>
Co-authored-by: Peter Steinberger <steipete@gmail.com>
Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Giuseppe Bisemi <giuseppe.bisemi@gmail.com>
Co-authored-by: HaiTao Wu <whtis@users.noreply.github.com>
Co-authored-by: Piotr Durlej <pdurlej@users.noreply.github.com>
Co-authored-by: zhulijin1991 <167979819+zhulijin1991@users.noreply.github.com>
Co-authored-by: zhulijin1991 <zhulijin1991@users.noreply.github.com>
Co-authored-by: iam-brain <94809115+iam-brain@users.noreply.github.com>
Co-authored-by: Bryan Font <bfont@me.com>
Co-authored-by: Jakub Hašek <kubahasek@users.noreply.github.com>
Co-authored-by: Radek Sienkiewicz <mail@velvetshark.com>
Co-authored-by: Larry Hao(郝卓远) <107194248+hhh2210@users.noreply.github.com>
LeoLin990405 pushed a commit to LeoLin990405/CodexBar that referenced this pull request Aug 6, 2026
Fixes steipete#944.

Refs steipete#946.

Co-authored-by: Jakub Hašek <kubahasek@users.noreply.github.com>
LeoLin990405 pushed a commit to LeoLin990405/CodexBar that referenced this pull request Aug 6, 2026
* Improve Kiro credits UX

* Add provider changelog links

* Fix changelog menu test

* feat: gate provider changelog links behind setting

* Address Kiro review feedback

* Polish Kiro credit detail styling

* fix: repair stale managed Codex account removal

* fix: handle Claude enterprise web accounts (steipete#941)

Fixes Claude Enterprise/organization web accounts by tolerating null session-window usage and exposing an optional organization ID field for Claude token accounts.

Local verification:
- swift test --filter 'ClaudeWebEnterpriseUsageTests|ProvidersPaneCoverageTests|ClaudeUsageTests'
- make check

Co-authored-by: Claude <noreply@anthropic.com>

* docs: update changelog for Claude enterprise fix

* fix: handle quota and usage edge cases

* Rebalance Kimi provider icon (steipete#912)

* Add zh-Hans translations for Claude peak hour labels (steipete#921)

* docs: update changelog for recent contributor fixes

* Add Tahoe menu bar visibility guidance

Co-authored-by: Piotr Durlej <pdurlej@users.noreply.github.com>

* Coalesce historical pace reset buckets

Co-authored-by: zhulijin1991 <zhulijin1991@users.noreply.github.com>

* Add Codex priority cost pricing

Co-authored-by: Bryan Font <bfont@me.com>

* fix: parse Claude web spend limits

* fix: refresh Gemini credentials without access token

* refactor: split Claude web extra usage helpers

* fix: defer account switcher menu rebuilds

Fixes steipete#944.

Refs steipete#946.

Co-authored-by: Jakub Hašek <kubahasek@users.noreply.github.com>

* docs: fix changelog spacing

* fix: handle unavailable Codex limits gracefully

* docs: update unreleased changelog

* fix: repair update and account menu paths

Co-authored-by: Radek Sienkiewicz <mail@velvetshark.com>

* fix: handle account-scoped usage and menu login bugs

* Add Antigravity account switching (steipete#937)

* Add Antigravity account switching

* Force Antigravity account chooser

* Persist Antigravity selected account updates

* docs: add Antigravity account switching changelog

---------

Co-authored-by: thiagocaltoe <thiago12_fera@hotmail.com>
Co-authored-by: Peter Steinberger <steipete@gmail.com>
Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Giuseppe Bisemi <giuseppe.bisemi@gmail.com>
Co-authored-by: HaiTao Wu <whtis@users.noreply.github.com>
Co-authored-by: Piotr Durlej <pdurlej@users.noreply.github.com>
Co-authored-by: zhulijin1991 <167979819+zhulijin1991@users.noreply.github.com>
Co-authored-by: zhulijin1991 <zhulijin1991@users.noreply.github.com>
Co-authored-by: iam-brain <94809115+iam-brain@users.noreply.github.com>
Co-authored-by: Bryan Font <bfont@me.com>
Co-authored-by: Jakub Hašek <kubahasek@users.noreply.github.com>
Co-authored-by: Radek Sienkiewicz <mail@velvetshark.com>
Co-authored-by: Larry Hao(郝卓远) <107194248+hhh2210@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants