Skip to content

Add zh-Hans translations for Claude peak hour labels - #921

Merged
steipete merged 1 commit into
steipete:mainfrom
whtis:night-shift/20260512-zh-peak-strings
May 14, 2026
Merged

Add zh-Hans translations for Claude peak hour labels#921
steipete merged 1 commit into
steipete:mainfrom
whtis:night-shift/20260512-zh-peak-strings

Conversation

@whtis

@whtis whtis commented May 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Backfills three Simplified Chinese strings that exist in en.lproj and pt-BR.lproj but are missing from zh-Hans.lproj:

  • off_peak → 非高峰
  • off_peak_peak_in → 非高峰 · %@ 后进入高峰
  • peak_ends_in → 高峰 · %@ 后结束

These keys ship the Claude peak-hours indicator label rendered by ClaudePeakHours.status. Without them, Chinese users fall back to the literal English/key text.

After this change, zh-Hans and en are key-equivalent (modulo the existing not_found entry, which is referenced by PreferencesDebugPane).

Verification

  • plutil -lint Sources/CodexBar/Resources/zh-Hans.lproj/Localizable.strings → OK
  • Diffed key sets between en.lproj and zh-Hans.lproj; no other gaps.
  • Insertion preserves alphabetical ordering to match en.lproj/pt-BR.lproj.

Drafted with AI assistance; verified by author before publishing.

@whtis
whtis marked this pull request as ready for review May 12, 2026 02:30
@steipete
steipete merged commit 6423275 into steipete:main May 14, 2026
1 check passed
steipete added a commit that referenced this pull request May 14, 2026
* Improve Kiro credits UX

* Add provider changelog links

* Fix changelog menu test

* feat: gate provider changelog links behind setting

* Address Kiro review feedback

* Polish Kiro credit detail styling

* fix: repair stale managed Codex account removal

* fix: handle Claude enterprise web accounts (#941)

Fixes Claude Enterprise/organization web accounts by tolerating null session-window usage and exposing an optional organization ID field for Claude token accounts.

Local verification:
- swift test --filter 'ClaudeWebEnterpriseUsageTests|ProvidersPaneCoverageTests|ClaudeUsageTests'
- make check

Co-authored-by: Claude <noreply@anthropic.com>

* docs: update changelog for Claude enterprise fix

* fix: handle quota and usage edge cases

* Rebalance Kimi provider icon (#912)

* Add zh-Hans translations for Claude peak hour labels (#921)

* docs: update changelog for recent contributor fixes

* Add Tahoe menu bar visibility guidance

Co-authored-by: Piotr Durlej <pdurlej@users.noreply.github.com>

* Coalesce historical pace reset buckets

Co-authored-by: zhulijin1991 <zhulijin1991@users.noreply.github.com>

* Add Codex priority cost pricing

Co-authored-by: Bryan Font <bfont@me.com>

* fix: parse Claude web spend limits

* fix: refresh Gemini credentials without access token

* refactor: split Claude web extra usage helpers

* fix: defer account switcher menu rebuilds

Fixes #944.

Refs #946.

Co-authored-by: Jakub Hašek <kubahasek@users.noreply.github.com>

* docs: fix changelog spacing

* fix: handle unavailable Codex limits gracefully

* docs: update unreleased changelog

* fix: repair update and account menu paths

Co-authored-by: Radek Sienkiewicz <mail@velvetshark.com>

* fix: handle account-scoped usage and menu login bugs

* Add Antigravity account switching (#937)

* Add Antigravity account switching

* Force Antigravity account chooser

* Persist Antigravity selected account updates

* docs: add Antigravity account switching changelog

---------

Co-authored-by: thiagocaltoe <thiago12_fera@hotmail.com>
Co-authored-by: Peter Steinberger <steipete@gmail.com>
Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Giuseppe Bisemi <giuseppe.bisemi@gmail.com>
Co-authored-by: HaiTao Wu <whtis@users.noreply.github.com>
Co-authored-by: Piotr Durlej <pdurlej@users.noreply.github.com>
Co-authored-by: zhulijin1991 <167979819+zhulijin1991@users.noreply.github.com>
Co-authored-by: zhulijin1991 <zhulijin1991@users.noreply.github.com>
Co-authored-by: iam-brain <94809115+iam-brain@users.noreply.github.com>
Co-authored-by: Bryan Font <bfont@me.com>
Co-authored-by: Jakub Hašek <kubahasek@users.noreply.github.com>
Co-authored-by: Radek Sienkiewicz <mail@velvetshark.com>
Co-authored-by: Larry Hao(郝卓远) <107194248+hhh2210@users.noreply.github.com>
LeoLin990405 pushed a commit to LeoLin990405/CodexBar that referenced this pull request Aug 6, 2026
LeoLin990405 pushed a commit to LeoLin990405/CodexBar that referenced this pull request Aug 6, 2026
* Improve Kiro credits UX

* Add provider changelog links

* Fix changelog menu test

* feat: gate provider changelog links behind setting

* Address Kiro review feedback

* Polish Kiro credit detail styling

* fix: repair stale managed Codex account removal

* fix: handle Claude enterprise web accounts (steipete#941)

Fixes Claude Enterprise/organization web accounts by tolerating null session-window usage and exposing an optional organization ID field for Claude token accounts.

Local verification:
- swift test --filter 'ClaudeWebEnterpriseUsageTests|ProvidersPaneCoverageTests|ClaudeUsageTests'
- make check

Co-authored-by: Claude <noreply@anthropic.com>

* docs: update changelog for Claude enterprise fix

* fix: handle quota and usage edge cases

* Rebalance Kimi provider icon (steipete#912)

* Add zh-Hans translations for Claude peak hour labels (steipete#921)

* docs: update changelog for recent contributor fixes

* Add Tahoe menu bar visibility guidance

Co-authored-by: Piotr Durlej <pdurlej@users.noreply.github.com>

* Coalesce historical pace reset buckets

Co-authored-by: zhulijin1991 <zhulijin1991@users.noreply.github.com>

* Add Codex priority cost pricing

Co-authored-by: Bryan Font <bfont@me.com>

* fix: parse Claude web spend limits

* fix: refresh Gemini credentials without access token

* refactor: split Claude web extra usage helpers

* fix: defer account switcher menu rebuilds

Fixes steipete#944.

Refs steipete#946.

Co-authored-by: Jakub Hašek <kubahasek@users.noreply.github.com>

* docs: fix changelog spacing

* fix: handle unavailable Codex limits gracefully

* docs: update unreleased changelog

* fix: repair update and account menu paths

Co-authored-by: Radek Sienkiewicz <mail@velvetshark.com>

* fix: handle account-scoped usage and menu login bugs

* Add Antigravity account switching (steipete#937)

* Add Antigravity account switching

* Force Antigravity account chooser

* Persist Antigravity selected account updates

* docs: add Antigravity account switching changelog

---------

Co-authored-by: thiagocaltoe <thiago12_fera@hotmail.com>
Co-authored-by: Peter Steinberger <steipete@gmail.com>
Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Giuseppe Bisemi <giuseppe.bisemi@gmail.com>
Co-authored-by: HaiTao Wu <whtis@users.noreply.github.com>
Co-authored-by: Piotr Durlej <pdurlej@users.noreply.github.com>
Co-authored-by: zhulijin1991 <167979819+zhulijin1991@users.noreply.github.com>
Co-authored-by: zhulijin1991 <zhulijin1991@users.noreply.github.com>
Co-authored-by: iam-brain <94809115+iam-brain@users.noreply.github.com>
Co-authored-by: Bryan Font <bfont@me.com>
Co-authored-by: Jakub Hašek <kubahasek@users.noreply.github.com>
Co-authored-by: Radek Sienkiewicz <mail@velvetshark.com>
Co-authored-by: Larry Hao(郝卓远) <107194248+hhh2210@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants