Fix Antigravity Gemini icon lanes and exhausted bar fill - #1631
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6038b529d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex review: needs changes before merge. Reviewed June 19, 2026, 3:29 AM ET / 07:29 UTC. Summary Reproducibility: yes. Source inspection gives a high-confidence path: enable merged icons and highest-usage selection, feed Antigravity quota-summary data with Claude/GPT high and Gemini low, and the provider can be selected by one lane while the icon renders another. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Copy recommended automerge instructionNext step before merge
Security Review findings
Review detailsBest possible solution: Keep the maintainer-approved current quota-summary-only Antigravity compact icon contract, but align merged highest-usage provider selection with the same rendered Gemini lanes before merge. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection gives a high-confidence path: enable merged icons and highest-usage selection, feed Antigravity quota-summary data with Claude/GPT high and Gemini low, and the provider can be selected by one lane while the icon renders another. Is this the best way to solve the issue? No. The quota-summary mapping, Warp fix, and progress-fill rounding are narrow, but the highest-usage merged-icon path still needs to use the same Antigravity lanes it renders or render the selected high-usage lane. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 5e38f6beb98d. Label changesLabel justifications:
Evidence reviewedAcceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
6038b52 to
36dcc3a
Compare
6fd1bea to
c390ec4
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c390ec4e1c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
c390ec4 to
de2fd3a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de2fd3a115
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
de2fd3a to
26eb9d0
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26eb9d0352
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| IconRemainingResolver.resolvedPercents( | ||
| snapshot: $0, | ||
| style: style, | ||
| style: resolverStyle, |
There was a problem hiding this comment.
Keep highest-usage mode on rendered lanes
In merged mode with menuBarShowsHighestUsage, primaryProviderForUnifiedIcon() still chooses Antigravity via providerWithHighestUsage()/MenuBarMetricWindowResolver, which can rank the provider by a high Claude+GPT quota-summary row. Passing the provider style here then renders only Antigravity's Gemini session/weekly lanes, so a provider can be selected because Claude+GPT is near its limit while the merged icon shows low Gemini usage instead of the quota that triggered the switch; please align the ranking with these rendered Gemini lanes or render the selected high-usage lane in this mode.
Useful? React with 👍 / 👎.
|
Exact-head maintainer proof for
Ready to land. |
Summary
Review and proof
make check: format and lint clean.Exact candidate:
26eb9d03529982f0856f8ef8f1c74551df8f7c2dScreenshots