Update Antigravity quota UI to sync with backend payload display names - #1584
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0bb3126a91
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
77c8229 to
8fb0850
Compare
|
Codex review: needs maintainer review before merge. Reviewed June 17, 2026, 12:29 PM ET / 16:29 UTC. Summary Reproducibility: yes. Source inspection shows current main receives backend displayName values in the quota-summary fixture but rewrites them to stale hardcoded labels; I did not run live provider probes because AGENTS.md warns against validation that may trigger account or Keychain prompts. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land this focused backend-name fix after maintainer approval, keeping the stable ID/keyword family grouping and coordinating only the small overlap with the adjacent model-label PR if it lands first. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection shows current main receives backend displayName values in the quota-summary fixture but rewrites them to stale hardcoded labels; I did not run live provider probes because AGENTS.md warns against validation that may trigger account or Keychain prompts. Is this the best way to solve the issue? Yes. Using backend displayName values for quota-summary groups and buckets, while keeping family selection on stable quota IDs or broad family keywords, is the narrow maintainable fix for this UI mismatch. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 05545feba362. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Maintainer proof for exact head
The ad-hoc GUI bundle triggered macOS Chrome Safe Storage/cross-app-data privacy prompts before menu interaction, even with browser cookie sources disabled, so I am not presenting a misleading fresh menu screenshot. Provider E2E above used the exact candidate and current Antigravity account/session. Existing PR screenshots plus focused menu/widget regression coverage remain applicable. |
Description
This PR addresses an Antigravity quota UI issue where CodexBar was overriding dynamic
displayNamefields from the quota summary payload with hardcoded strings like"Gemini Session"or"Claude + GPT Weekly".This change updates
AntigravityStatusProbeand related UI formatting logic to use the real strings provided by the Google AI Studio backend, matching the web dashboard terminology.Note: this PR is about Antigravity quota display names and menu-bar quota selection. It is not the Safari / ChatGPT Atlas cookie-import issue from #1548.
Changes Made
"Gemini"and"Claude + GPT"inAntigravityStatusProbeand replaced them with backend payload names such as"Gemini Models"and"Claude and GPT models".quotaSummaryRepresentativepredicate matching to rely on broad keywords instead of exact prefixes.AntigravityProviderDescriptordefault labels to"Gemini Models"and"Claude and GPT".Before & After Evidence
The CodexBar status menu now aligns with the Antigravity web dashboard terminology:
Testing
swift test --filter CodexBarWidgetProviderTestsswift test --filter MenuBarMetricWindowResolverTestsswift test --filter Antigravity(197 tests passed)