Skip to content

Prove Claude cookie cache isolation #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steipete merged 2 commits into from
Jun 15, 2026
Merged

Prove Claude cookie cache isolation #1539

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a82fd86
Prove Claude cookie cache isolation
ProspectOre Jun 15, 2026
89f7ae8
test: isolate Claude cookie proof storage
steipete Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 127 additions & 0 deletions Tests/CodexBarTests/CookieHeaderCacheTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,119 @@ struct CookieHeaderCacheTests {
#expect(CookieHeaderCache.load(provider: provider, scope: .managedAccount(UUID())) == nil)
}

@Test
func `claude cookie scopes isolate browser cache from managed accounts`() {
self.withIsolatedCookieCache {
let accountA = UUID()
let accountB = UUID()

CookieHeaderCache.store(
provider: .claude,
cookieHeader: "sessionKey=sk-ant-browser",
sourceLabel: "Safari")
CookieHeaderCache.store(
provider: .claude,
scope: .managedAccount(accountA),
cookieHeader: "sessionKey=sk-ant-account-a",
sourceLabel: "Chrome")
CookieHeaderCache.store(
provider: .claude,
scope: .managedAccount(accountB),
cookieHeader: "sessionKey=sk-ant-account-b",
sourceLabel: "Edge")

#expect(CookieHeaderCache.load(provider: .claude)?.cookieHeader == "sessionKey=sk-ant-browser")
#expect(CookieHeaderCache.load(provider: .claude, scope: .managedAccount(accountA))?
.cookieHeader == "sessionKey=sk-ant-account-a")
#expect(CookieHeaderCache.load(provider: .claude, scope: .managedAccount(accountB))?
.cookieHeader == "sessionKey=sk-ant-account-b")

CookieHeaderCache.clear(provider: .claude)
#expect(CookieHeaderCache.load(provider: .claude) == nil)
#expect(CookieHeaderCache.load(provider: .claude, scope: .managedAccount(accountA))?
.cookieHeader == "sessionKey=sk-ant-account-a")
#expect(CookieHeaderCache.load(provider: .claude, scope: .managedAccount(accountB))?
.cookieHeader == "sessionKey=sk-ant-account-b")

CookieHeaderCache.clear(provider: .claude, scope: .managedAccount(accountA))
#expect(CookieHeaderCache.load(provider: .claude, scope: .managedAccount(accountA)) == nil)
#expect(CookieHeaderCache.load(provider: .claude, scope: .managedAccount(accountB))?
.cookieHeader == "sessionKey=sk-ant-account-b")
}
}

@Test
func `claude unreadable managed store sentinel is isolated from account cookies`() {
self.withIsolatedCookieCache {
let accountID = UUID()

CookieHeaderCache.store(
provider: .claude,
cookieHeader: "sessionKey=sk-ant-global",
sourceLabel: "Safari")
CookieHeaderCache.store(
provider: .claude,
scope: .managedAccount(accountID),
cookieHeader: "sessionKey=sk-ant-account",
sourceLabel: "Chrome")
CookieHeaderCache.store(
provider: .claude,
scope: .managedStoreUnreadable,
cookieHeader: "sessionKey=sk-ant-unreadable-store",
sourceLabel: "Unreadable managed account store")

CookieHeaderCache.clear(provider: .claude, scope: .managedAccount(accountID))
#expect(CookieHeaderCache.load(provider: .claude, scope: .managedAccount(accountID)) == nil)
#expect(CookieHeaderCache.load(provider: .claude)?.cookieHeader == "sessionKey=sk-ant-global")
#expect(CookieHeaderCache.load(provider: .claude, scope: .managedStoreUnreadable)?
.cookieHeader == "sessionKey=sk-ant-unreadable-store")

CookieHeaderCache.clear(provider: .claude)
#expect(CookieHeaderCache.load(provider: .claude) == nil)
#expect(CookieHeaderCache.load(provider: .claude, scope: .managedStoreUnreadable)?
.cookieHeader == "sessionKey=sk-ant-unreadable-store")

let cleared = CookieHeaderCache.clearAllScopesDetailed(provider: .claude)
#expect(cleared == CookieHeaderCache.ClearSummary(clearedCount: 1, failedCount: 0))
#expect(CookieHeaderCache.load(provider: .claude, scope: .managedStoreUnreadable) == nil)
}
}

@Test
func `claude clear all scopes does not remove other provider cookie caches`() {
self.withIsolatedCookieCache {
let claudeAccount = UUID()
let codexAccount = UUID()

CookieHeaderCache.store(
provider: .claude,
cookieHeader: "sessionKey=sk-ant-claude-global",
sourceLabel: "Safari")
CookieHeaderCache.store(
provider: .claude,
scope: .managedAccount(claudeAccount),
cookieHeader: "sessionKey=sk-ant-claude-account",
sourceLabel: "Chrome")
CookieHeaderCache.store(provider: .codex, cookieHeader: "auth=codex-global", sourceLabel: "Chrome")
CookieHeaderCache.store(
provider: .codex,
scope: .managedAccount(codexAccount),
cookieHeader: "auth=codex-account",
sourceLabel: "Safari")
CookieHeaderCache.store(provider: .perplexity, cookieHeader: "pplx=web", sourceLabel: "Chrome")

let cleared = CookieHeaderCache.clearAllScopesDetailed(provider: .claude)

#expect(cleared == CookieHeaderCache.ClearSummary(clearedCount: 2, failedCount: 0))
#expect(CookieHeaderCache.load(provider: .claude) == nil)
#expect(CookieHeaderCache.load(provider: .claude, scope: .managedAccount(claudeAccount)) == nil)
#expect(CookieHeaderCache.load(provider: .codex)?.cookieHeader == "auth=codex-global")
#expect(CookieHeaderCache.load(provider: .codex, scope: .managedAccount(codexAccount))?
.cookieHeader == "auth=codex-account")
#expect(CookieHeaderCache.load(provider: .perplexity)?.cookieHeader == "pplx=web")
}
}

@Test
func `migrates legacy file to keychain`() {
KeychainCacheStore.setTestStoreForTesting(true)
Expand Down Expand Up @@ -660,4 +773,18 @@ struct CookieHeaderCacheTests {
#expect(KeychainCacheStore.keys(category: "cookie").isEmpty)
}
}

private func withIsolatedCookieCache<T>(_ operation: () -> T) -> T {
KeychainCacheStore.withServiceOverrideForTesting("cookie-isolation-\(UUID().uuidString)") {
let legacyBase = FileManager.default.temporaryDirectory
.appendingPathComponent(UUID().uuidString, isDirectory: true)
CookieHeaderCache.setLegacyBaseURLOverrideForTesting(legacyBase)
defer { CookieHeaderCache.setLegacyBaseURLOverrideForTesting(nil) }
KeychainCacheStore.setTestStoreForTesting(true)
defer { KeychainCacheStore.setTestStoreForTesting(false) }
CookieHeaderCache.resetDisplayCacheForTesting()
defer { CookieHeaderCache.resetDisplayCacheForTesting() }
return operation()
}
}
}