Prove Claude cookie cache isolation - #1539
Merged
steipete merged 2 commits intoJun 15, 2026
Merged
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 15, 2026, 12:49 AM ET / 04:49 UTC. Summary Reproducibility: not applicable. this is a test-only PR rather than a standalone bug report. The contributor provided terminal transcripts for the focused test suite and repository checks, and source inspection shows the tested cache paths clearly. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the focused storage-isolation tests if maintainers want this proof slice, while keeping runtime Claude auth renewal and lifecycle decisions in the linked canonical work. Do we have a high-confidence way to reproduce the issue? Not applicable; this is a test-only PR rather than a standalone bug report. The contributor provided terminal transcripts for the focused test suite and repository checks, and source inspection shows the tested cache paths clearly. Is this the best way to solve the issue? Yes; focused CookieHeaderCache tests are the narrow maintainable way to prove this storage-isolation slice without changing runtime Claude auth behavior. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against b3f74cabeb52. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
clawsweeper
Bot
added
rating: 🦪 silver shellfish
Contributor
Author
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Contributor
Author
|
Proof transcript for PR #1539, part 1 of 2. |
Contributor
Author
|
Proof transcript for PR #1539, part 2 of 2. |
Contributor
Author
|
@clawsweeper re-review |
clawsweeper
Bot
added
proof: sufficient
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Issue #1287 is still open for broader Claude auth lifecycle closure criteria, including storage behavior and account isolation. This PR adds focused proof for the cookie-cache storage and isolation piece without changing runtime behavior.
This does not claim to close #1287 by itself; it covers the storage/account-isolation test slice only.
Proof
Local
swift test --filter CookieHeaderCacheTests:Local
make check:Full terminal transcript for this branch:
CI artifacts for this branch:
Refs #1287