feat: Add UI and hooks for pre-deposit functionality #816

gbonumore · 2025-10-17T14:53:44Z

Added useApprovePreDepositToken hook for token approval process.
Implemented useExchangeRate hook to fetch token exchange rates from Binance.
Developed useMaxPreDepositValue hook to read maximum deposit amount for a user.
Introduced usePreDepositStateContext and usePreDepositStateMachine for managing pre-deposit state.
Created usePreDepositVault hook for depositing tokens into a vault.
Updated DashboardPage to include vault selection and pre-deposit modal.

closes #775

changeset-bot · 2025-10-17T14:53:48Z

🦋 Changeset detected

Latest commit: dbfbbf7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
hub	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-10-17T14:53:50Z

@gbonumore is attempting to deploy a commit to the Status Team on Vercel.

A member of the Team first needs to authorize it.

apps/hub/src/app/_components/vault-card.tsx

iamonuwa · 2025-10-20T17:54:31Z

apps/hub/src/app/_components/vault-card.tsx

  const { name, apy, rewards, icon, onDeposit } = props
  const apyValue = apy.endsWith('%') ? apy.slice(0, -1) : apy
-  const rewardsLine = rewards.join(', ')
+  const rewardsLine = rewards.map(reward => reward.name).join(', ')


what are the chances that reward.name is not undefined?

this is defined by us, since it's required this would not compile

apps/hub/src/app/_constants/address.ts

JulesFiliot

All good, just some magic numbers.

Also an open question but why don't we use SVGs for icons?

apps/hub/src/app/_components/pre-deposit-modal.tsx

JulesFiliot · 2025-10-21T04:49:30Z

apps/hub/src/app/_components/pre-deposit-modal.tsx

+      .with({ exchangeRate: P.nullish }, () => 0)
+      .with({ amountInputNumber: P.when(n => isNaN(n) || n <= 0) }, () => 0)
+      .with({ calculatedUSD: P.when(n => !isFinite(n)) }, () => null)
+      .with({ calculatedUSD: P.when(n => n > 1_000_000_000_000) }, () => null)


There must be a good reason but why 1_000_000_000_000 specifically?

This is to avoid insanely dollar values and do useless api calls, so this check might not be even here (this is more or less the same UX swap protocols offer when you try to input unreal money) feel free to change this number to a fair value that doesn't break UI or directly on the API call to prevent the call to be fired

JulesFiliot · 2025-10-21T04:59:53Z

apps/hub/src/app/_hooks/useExchangeRate.ts

+    enabled,
+    refetchInterval,
+    staleTime,
+    retry: 3,


magic number

This is indeed you might want to setup default retries on the queryclient config

JulesFiliot · 2025-10-21T05:03:03Z

apps/hub/src/utils/currency.ts

+  options: Omit<FormatTokenOptions, 'tokenDecimals'> = {}
+): string {
+  return formatTokenAmount(amount, 'ETH', {
+    decimals: 4, // Default to 4 decimals for ETH


magic number

This file comes from #811 so you guys want to address these on that PR first

JulesFiliot · 2025-10-21T05:03:26Z

apps/hub/src/utils/currency.ts

+): string {
+  return formatTokenAmount(amount, 'KARMA', {
+    ...options,
+    tokenDecimals: 0, // KARMA values are already in display units


magic number

JulesFiliot · 2025-10-21T05:04:17Z

apps/hub/src/utils/currency.ts

+): string {
+  const {
+    currency = 'USD',
+    tokenDecimals = 0, // Default to 0 for currency values (already in display units)


magic number

JulesFiliot

App is not building anymore due to mismatching types names

apps/hub/src/app/_components/vault-card.tsx

apps/hub/src/app/_constants/address.ts

apps/hub/src/app/_hooks/useApprovePreDepositToken.ts

jinhojang6 · 2025-10-27T12:42:36Z

I can't build this branch yet with the following error:

wallet:build:  ERROR  [vite:define] The service was stopped: write EPIPE                                                                                
wallet:build:  ELIFECYCLE  Command failed with exit code 1.
wallet:build:  ELIFECYCLE  Command failed with exit code 1.
...
status.app#build: command (/Users/.../status-web/apps/status.app) /Users/jinhojang/Library/pnpm/.tools/@pnpm+macos-arm64/9.12.3/bin/pnpm run build exited (1)

vercel · 2025-10-29T13:36:27Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
status-network-hub	Ready	Preview	Comment	Oct 29, 2025 1:39pm

JulesFiliot · 2025-10-31T07:28:11Z

I can't build this branch yet with the following error:

wallet:build:  ERROR  [vite:define] The service was stopped: write EPIPE                                                                                
wallet:build:  ELIFECYCLE  Command failed with exit code 1.
wallet:build:  ELIFECYCLE  Command failed with exit code 1.
...
status.app#build: command (/Users/.../status-web/apps/status.app) /Users/jinhojang/Library/pnpm/.tools/@pnpm+macos-arm64/9.12.3/bin/pnpm run build exited (1)

@jinhojang6 at the root this should work:

nvm use 20 && pnpm install && pnpm build
# even if the status.app & wallet builds fail, the command bellow should then work correctly
pnpm --filter "hub" dev

After that you can also check that the build of the hub passes by doing

pnpm -r --filter "...hub" build

jinhojang6 · 2025-10-31T08:46:03Z

@JulesFiliot

I ran nvm use 20 && pnpm install && pnpm build but got the same error.

wallet:build:  ERROR  [vite:esbuild] The service was stopped                                                                                            5:41:55 PM
wallet:build: file: /Users/jinhojang/Desktop/work/status-web/apps/wallet/src/data/bitcoin/mempool.ts

...

wallet:build:  ERROR  Failed to build background, page                                                                                                  5:41:55 PM
wallet:build: 
wallet:build:     at buildEntrypoints
...

The build process itself is not working, although I retried it after removing node_modules.

But pnpm --filter "hub" dev definitely works

felicio · 2025-11-03T07:23:09Z

apps/hub/package.json

    "clean": "rimraf .next .vercel/output node_modules"
  },
  "dependencies": {
+    "@radix-ui/react-dialog": "^1.1.1",


todo: trigger dialog from sidebar's Deposit menu item as well https://www.figma.com/design/1XbZL2WrTG5DqJO8DovE0H/Website----status.network?node-id=5098-21598&m=dev

- Added useApprovePreDepositToken hook for token approval process. - Implemented useExchangeRate hook to fetch token exchange rates from Binance. - Developed useMaxPreDepositValue hook to read maximum deposit amount for a user. - Introduced usePreDepositStateContext and usePreDepositStateMachine for managing pre-deposit state. - Created usePreDepositVault hook for depositing tokens into a vault. - Updated DashboardPage to include vault selection and pre-deposit modal.

Co-authored-by: Onuwa Nnachi Isaac <[email protected]>

…osit modal

github-project-automation bot added this to Web & User Interfaces Oct 17, 2025

github-project-automation bot moved this to In Progress in Web & User Interfaces Oct 17, 2025

felicio requested review from a team, JulesFiliot, felicio, jinhojang6 and jkbktl October 18, 2025 01:25

iamonuwa reviewed Oct 20, 2025

View reviewed changes

apps/hub/src/app/_components/vault-card.tsx Outdated Show resolved Hide resolved

iamonuwa reviewed Oct 20, 2025

View reviewed changes

apps/hub/src/app/_constants/address.ts Outdated Show resolved Hide resolved

iamonuwa reviewed Oct 20, 2025

View reviewed changes

apps/hub/src/app/_constants/address.ts Outdated Show resolved Hide resolved

JulesFiliot reviewed Oct 21, 2025

View reviewed changes

JulesFiliot requested changes Oct 22, 2025

View reviewed changes

github-project-automation bot moved this from In Progress to ToDo in Web & User Interfaces Oct 22, 2025

JulesFiliot approved these changes Oct 23, 2025

View reviewed changes

github-project-automation bot moved this from ToDo to Waiting in Web & User Interfaces Oct 23, 2025

vercel bot deployed to Preview – status-network-hub October 29, 2025 13:39 View deployment

felicio reviewed Nov 3, 2025

View reviewed changes

jkbktl changed the base branch from feat/wallet-connect to main November 5, 2025 11:45

gbonumore and others added 5 commits November 5, 2025 13:47

Update apps/hub/src/app/_components/vault-card.tsx

13b5c1b

Co-authored-by: Onuwa Nnachi Isaac <[email protected]>

feat: Implement minimum deposit value hook and integrate into pre-dep…

6a6968a

…osit modal

fix: update types for Reward and Token

3a2c4f7

add dialog to sidebar

15d2620

jkbktl force-pushed the feat/add-deposit-section branch from 67e527e to 15d2620 Compare November 5, 2025 12:53

jkbktl changed the base branch from main to release/hub November 5, 2025 12:55

Create poor-shoes-hear.md

dbfbbf7

feat: Add UI and hooks for pre-deposit functionality #816

Are you sure you want to change the base?

feat: Add UI and hooks for pre-deposit functionality #816

Conversation

gbonumore commented Oct 17, 2025 • edited by felicio Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Oct 17, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JulesFiliot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gbonumore Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JulesFiliot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jinhojang6 commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JulesFiliot commented Oct 31, 2025

Uh oh!

jinhojang6 commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gbonumore commented Oct 17, 2025 •

edited by felicio

Loading

changeset-bot bot commented Oct 17, 2025 •

edited

Loading

gbonumore Oct 21, 2025 •

edited

Loading

jinhojang6 commented Oct 27, 2025 •

edited

Loading

vercel bot commented Oct 29, 2025 •

edited

Loading

jinhojang6 commented Oct 31, 2025 •

edited

Loading