Skip to content

Conversation

@jkbktl
Copy link
Contributor

@jkbktl jkbktl commented Sep 1, 2025

fixes disappearance of the recent NFT

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2025

🦋 Changeset detected

Latest commit: 6c6ebd8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@status-im/wallet Patch
wallet Patch
portfolio Patch
api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 1, 2025

@jkbktl is attempting to deploy a commit to the Status Team on Vercel.

A member of the Team first needs to authorize it.

@status-im-auto
Copy link
Member

status-im-auto commented Sep 2, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ fcfbb73 #3 2025-09-02 10:20:04 ~1 min wallet 📦zip
✔️ 6c6ebd8 #4 2025-09-02 10:27:23 ~32 sec connector 📦zip
✔️ 6c6ebd8 #4 2025-09-02 10:27:57 ~1 min wallet 📦zip

@jkbktl jkbktl marked this pull request as ready for review September 2, 2025 10:37
Copilot AI review requested due to automatic review settings September 2, 2025 10:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where recently acquired NFTs were disappearing from the collectibles display by adding ordering parameters to the Alchemy API request.

  • Adds orderBy parameter to the NFT fetching API call to sort by transfer time
  • Includes a changeset documenting the collectibles fix

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/wallet/src/data/services/alchemy/index.ts Adds orderBy parameter to sort NFTs by transfer time
.changeset/unlucky-planets-brake.md Documents the collectibles fix in changeset

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@felicio felicio requested review from a team, felicio and marcelines September 2, 2025 11:48
@github-project-automation github-project-automation bot moved this from In Progress to Waiting in Web & User Interfaces Sep 2, 2025
@jkbktl jkbktl merged commit c7a6e71 into status-im:main Sep 2, 2025
3 of 6 checks passed
@jkbktl jkbktl deleted the fix/collectibles branch September 2, 2025 18:46
@github-project-automation github-project-automation bot moved this from Waiting to Done in Web & User Interfaces Sep 2, 2025
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future reference: changes to cache would not apply for use case when api exposed in a separate project called via trpc fetchRequestHandler with fetch from apps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants