-
Notifications
You must be signed in to change notification settings - Fork 47
fix collectibles #789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix collectibles #789
Conversation
🦋 Changeset detectedLatest commit: 6c6ebd8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@jkbktl is attempting to deploy a commit to the Status Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue where recently acquired NFTs were disappearing from the collectibles display by adding ordering parameters to the Alchemy API request.
- Adds
orderByparameter to the NFT fetching API call to sort by transfer time - Includes a changeset documenting the collectibles fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/wallet/src/data/services/alchemy/index.ts | Adds orderBy parameter to sort NFTs by transfer time |
| .changeset/unlucky-planets-brake.md | Documents the collectibles fix in changeset |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for future reference: changes to cache would not apply for use case when api exposed in a separate project called via trpc fetchRequestHandler with fetch from apps
fixes disappearance of the recent NFT