-
Notifications
You must be signed in to change notification settings - Fork 47
add new wallet #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new wallet #696
Conversation
🦋 Changeset detectedLatest commit: 481b13d The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@jkbktl is attempting to deploy a commit to the Status Team on Vercel. A member of the Team first needs to authorize it. |
Jenkins BuildsClick to see older builds (8)
|
| }) | ||
| }, | ||
| onSuccess: () => { | ||
| queryClient.invalidateQueries({ queryKey: ['wallets'] }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't have distinct key from "create"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's invalidating query which has queryKey wallets and since we want to fetch same query in both cases, we need to invalidate same queryKey.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't queryKye support array and with it allow distinct and more descriptive keys https://tanstack.com/query/v5/docs/framework/react/guides/query-keys#simple-query-keys ?
closes #684
This PR introduces flow for new wallet creation.
requirements:
notes:
/portfoliowhere they getmnemonicvialocation.state, so it can be shownWalletProviderto access Wallet data viauseWallet()hook