Skip to content

Conversation

@jkbktl
Copy link
Contributor

@jkbktl jkbktl commented Jun 2, 2025

closes #684

This PR introduces flow for new wallet creation.

requirements:

  • password lengths: min - 12chars and max -128chars,
  • password should have at least one: lower case, upper case, number, symbol

notes:

  • implemented zxcvbn-ts for password strength check
  • after wallet is created user is redirected to /portfolio where they get mnemonic via location.state, so it can be shown
  • implemented WalletProvider to access Wallet data via useWallet() hook
  • implemented checks if user already has wallet - redirect to portfolio, if they hasn't - redirect to onboarding
  • recovery phrase UI was created as side effect, will be solved in different PR

@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2025

🦋 Changeset detected

Latest commit: 481b13d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@status-im/wallet Patch
wallet Patch
portfolio Patch
api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 2, 2025

@jkbktl is attempting to deploy a commit to the Status Team on Vercel.

A member of the Team first needs to authorize it.

@felicio felicio linked an issue Jun 2, 2025 that may be closed by this pull request
@jkbktl jkbktl self-assigned this Jun 3, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Jun 4, 2025

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d8882b2 #1 2025-06-04 12:24:12 ~47 sec wallet 📦zip
✔️ 2f39688 #2 2025-06-09 22:12:09 ~51 sec wallet 📦zip
✔️ f630013 #3 2025-06-10 20:48:23 ~48 sec wallet 📦zip
✔️ d09c91f #4 2025-06-10 20:52:02 ~47 sec wallet 📦zip
✔️ d06e764 #5 2025-06-10 20:53:51 ~47 sec wallet 📦zip
✔️ 51b576c #7 2025-06-10 21:15:31 ~52 sec wallet 📦zip
✔️ 57625b8 #8 2025-06-15 22:22:43 ~1 min wallet 📦zip
✔️ 6f87870 #9 2025-06-18 21:41:38 ~1 min wallet 📦zip
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b41e11d #10 2025-06-18 23:48:09 ~55 sec wallet 📦zip
✔️ 61a859d #11 2025-06-19 07:24:01 ~53 sec wallet 📦zip

@felicio felicio mentioned this pull request Jun 10, 2025
@jkbktl jkbktl force-pushed the feat/onboarding branch from f630013 to d09c91f Compare June 10, 2025 20:50
@jkbktl jkbktl marked this pull request as ready for review June 10, 2025 23:49
@jkbktl jkbktl requested review from a team, felicio and marcelines June 10, 2025 23:49
})
},
onSuccess: () => {
queryClient.invalidateQueries({ queryKey: ['wallets'] })
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't have distinct key from "create"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's invalidating query which has queryKey wallets and since we want to fetch same query in both cases, we need to invalidate same queryKey.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't queryKye support array and with it allow distinct and more descriptive keys https://tanstack.com/query/v5/docs/framework/react/guides/query-keys#simple-query-keys ?

@felicio felicio merged commit d354913 into status-im:main Jun 19, 2025
3 of 6 checks passed
@github-project-automation github-project-automation bot moved this from 🚧 In Progress to Done in Web & User Interfaces Jun 19, 2025
@jkbktl jkbktl deleted the feat/onboarding branch August 1, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

As a user, I want to create Ethereum address in my wallet

3 participants